-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Day Mix/Max Values in Tiles Do Not reset at Midnight #198
Comments
Hi Gary, I implemented this and it would be great if you could test this out if you got some time! I attached an updated file: live-updates.zip. Please de-compress and copy the file to the |
I have installed the file and I do get the test message after reloading. Gary |
When I installed the new file, I restarted WeeWX (not really required) and CTL-F5 to refresh the browser cache. |
A bug, I wasn't aware of, but I fixed it, attached is an updated file (the message is now "test 2").
That seems a bit odd, does Apparent Temperature gets regularly updated on MQTT updates? For every observation that's in the message which arrives on a new day, the min and max values will be set to the current value. So if appTemp does not get reset, it seems that it was missing from that MQTT message. Any idea how this could be the case? Can you subscribe to your MQTT Broker and watch for appTemp in the messages? |
Test 2 fixed wiping the min/max values on refresh. Let's see what happens in the AM |
That means appTemp is never updated, right? I guess the topics Do you have any special/overridden MQTT config in weewx.conf? |
No, the value is there, just not when you are expecting it. |
I'll double check the MQTT config in the morning, but there isn't any customization. |
Ah, I think I got you now. So Ok, I did not think about this when I added the min/max reset, I will send you an updated file for further tests, probably tomorrow! |
Let's hold off on changes. I need to investigate the differences between the WLL and console logger. Let me see if I can use the 'production' machines MQTT on the test machine's skin. |
It is not possible to use the secure ws with unsecure page. |
It is! The other way around is not possible: Using insecure MQTT WS with a secure page. I am testing with such a setup: Insecure page with secure WS, without any problems. Currently, the min/max values are reset for every observation, that is included in the first messages on a new day. I was wondering if your setup is causing this, so its an exception or if this could be a common behaviour that not all observations are included? |
I'd be interested in your test setup as I was not able to get a connection to my other, secure mosquitto server. In any event, the feed from the WLL is not providing appTemp in every loop packet. It could be the driver, it could be the WLL. Either way, it is only there on the 5s Here's some info on the feed: |
I am just using my secure production Server for local testing:
Page is simple HTTP, no https:
I could imagine that this is not the only way something like this could happen. Here is another test file (the message says "test 3"), please test this one out. It should hopefully also reset |
Ah, I was attempting to use it but locally (.lan not the public address). I'll update in the AM. |
Min/max reset overnight. Unless you need it for tracking, feel free to close this. Gary |
Great! I will then close this issue for now, the change will be included in the next 3.4.0 update, feel free to open another issue if you encounter any problems! |
Reopening this. |
Describe the bug
In v3.3.0 and all earlier versions, the max value on any tile does not refresh at midnight. If I manually refresh the page, correct min/max values are shown.
To Reproduce
Steps to reproduce the behavior:
The mix/max values should be reset for the new day.
This is really noticeable with the weather we've had this summer.
The text was updated successfully, but these errors were encountered: