Skip to content

feat(Bimex): auditar-vite-pinata-secret-confirmar-que-sea-jwt - #286

Merged
David1984TK merged 2 commits into
David1984TK:mainfrom
Caneryy:feat/issue-145
Jul 31, 2026
Merged

feat(Bimex): auditar-vite-pinata-secret-confirmar-que-sea-jwt#286
David1984TK merged 2 commits into
David1984TK:mainfrom
Caneryy:feat/issue-145

Conversation

@Caneryy

@Caneryy Caneryy commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Closes #145

Summary

  • Auditar VITE_PINATA_SECRET: confirmar que sea JWT público o moverlo a proxy backend

Test plan

  • Relevant tests pass locally
  • Manual verification on affected UI or API paths

@Caneryy
Caneryy requested a review from David1984TK as a code owner July 29, 2026 01:09
@drips-wave

drips-wave Bot commented Jul 29, 2026

Copy link
Copy Markdown

@Caneryy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@David1984TK

David1984TK commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Buen trabajo de auditoría — el decision record en docs/decision-vite-pinata-secret.md es justo lo que le faltaba a #145 para cerrar del todo, y el test unitario nuevo en ipfs.test.js (confirma que subirAIPFS pega a /ipfs-upload y nunca a api.pinata.cloud) es sólido y ya pasa.

Lo único que bloquea el merge: el E2E nuevo (e2e/ipfs-upload.spec.ts) falla con Test timeout of 30000ms exceeded en un .click(), consistente en los 3 intentos — es el único test que falla de toda la suite (todo lo demás, incluido el resto de Playwright, pasa). No pude aislar rápido cuál click es (el log no lo específica), pero por el flujo probablemente es el botón "Crear" inicial en /proyectos" que nunca queda visible/clickeable, o el generateBtn" ("Generar huella digital") que depende del hash de los 3 documentos completándose antes del timeout.

Con ese E2E arreglado (o si preferís, quitado de este PR y mandado aparte cuando lo tengas estable), esto queda mergeable tal cual.

@David1984TK
fix(e2e): use taller viewport for ipfs-upload spec, dedupe React key
9b0d1fe 
The create-project dialog is taller than Playwright's default 720px
viewport; its submit button sat below the fold inside the dialog's own
scroll container, so the click actionability check kept reporting
"element is outside of the viewport" until the 30s test timeout (root
cause of the failing check on this PR, not an app regression).

Also fixes a real key-collision bug found while debugging: the IPFS
doc list keyed by <div key={cid}> duplicates React keys whenever two
uploaded docs resolve to the same CID (exactly what the new mocked
E2E does with MOCK_CID for all three files) — keyed by the fixed
label (INE/Plan/Presupuesto) instead, which is always unique.

26/26 Playwright specs and 142/142 vitest tests green locally.
@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

@David1984TK is attempting to deploy a commit to the david1984tk's projects Team on Vercel.

A member of the Team first needs to authorize it.

David1984TK
David1984TK approved these changes Jul 31, 2026
View reviewed changes

@David1984TK David1984TK left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI real en verde (26/26 Playwright, 142/142 vitest) tras el fix del viewport. El decision record y los tests que agrega este PR quedan bien. Aprobado.

@David1984TK
David1984TK merged commit 41bfbcd into David1984TK:main Jul 31, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@David1984TK David1984TK David1984TK approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Auditar VITE_PINATA_SECRET: confirmar que sea JWT público o moverlo a proxy backend

2 participants

@Caneryy @David1984TK