Check mode is broken, add redis binaries to alternatives fail no attribute stdout_lines

[HugoPoi]

With Ansible version 2.8.4 in check mode the task add redis binaries to alternatives failed with a 'dict object' has no attribute 'stdout_lines'.

TASK [DavidWittman.redis : list redis binaries to add to alternatives] *********
skipping: [dev] => {"changed": false, "msg": "skipped, running in check mode"}
TASK [DavidWittman.redis : add redis binaries to alternatives] *****************
fatal: [dev]: FAILED! => {"msg": "'dict object' has no attribute 'stdout_lines'"}

ansible-redis/tasks/install.yml

Lines 63 to 74 in 98bef17

	- name: list redis binaries to add to alternatives
	command: ls -1 {{ redis_install_dir }}/bin
	register: redis_binaries
	changed_when: false
	- name: add redis binaries to alternatives
	alternatives:
	name: "{{ item }}"
	path: "{{ redis_install_dir }}/bin/{{ item }}"
	link: "/usr/bin/{{ item }}"
	with_items: "{{ redis_binaries.stdout_lines }}"
	when: redis_binaries is succeeded

I think the task list redis binaries to add to alternatives can have check_mode: no because it's read-only stuff. And a | default([]) in the with_items.

[HugoPoi]

After investigating a little more, this role doesn't handle well the check mode. I see #202 fix some stuff and go in the right direction I think.

[camjay]

I addressed this specific issue in #264 which has been merged.

If you use the current master version by adding this to your requirements you should find this is resolved:

  - src: https://github.com/DavidWittman/ansible-redis
    version: 'b1edec047232c3f226677fb89a0bbdc4670701fa'
    name: davidwittman.redis

[DavidWittman]

Closed by #264