Skip to content

Commit 502b17a

Browse files
committed
Rails 5 support.
1 parent 7688d3a commit 502b17a

File tree

7 files changed

+29
-5
lines changed

7 files changed

+29
-5
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
.config
66
.yardoc
77
Gemfile.lock
8+
gemfiles/*.lock
9+
vendor/
810
InstalledFiles
911
_yardoc
1012
coverage

.travis.yml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,18 @@
11
rvm:
2-
- 2.0.0
32
- 2.1.0
3+
- 2.2.0
44

55
before_install:
66
- gem install bundler -v '= 1.5.1'
77

8+
gemfile:
9+
- gemfiles/Gemfile.4.2
10+
- gemfiles/Gemfile.5.0
11+
12+
exclude:
13+
- gemfile: gemfiles/Gemfile.5.0
14+
rvm: 2.1
15+
816
notifications:
917
hipchat:
1018
rooms:

destroyed_at.gemspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ Gem::Specification.new do |spec|
1919

2020
spec.required_ruby_version = '~> 2.0'
2121

22-
spec.add_runtime_dependency "activerecord", '~> 4.1'
23-
spec.add_runtime_dependency 'actionpack', '~> 4.1'
22+
spec.add_runtime_dependency "activerecord", '>= 4.1'
23+
spec.add_runtime_dependency 'actionpack', '>= 4.1'
2424

2525
spec.add_development_dependency "bundler", "~> 1.3"
2626
spec.add_development_dependency "rake"

gemfiles/Gemfile.4.2

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
source 'https://rubygems.org'
2+
3+
# Specify your gem's dependencies in destroyed_at.gemspec
4+
gemspec :path => "../"
5+
gem 'm', github: 'unmanbearpig/m'
6+
gem "activerecord", "~> 4.2.0"

gemfiles/Gemfile.5.0

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
source 'https://rubygems.org'
2+
3+
# Specify your gem's dependencies in destroyed_at.gemspec
4+
gemspec :path => "../"
5+
gem 'm', github: 'unmanbearpig/m'
6+
gem "activerecord", "~> 5.0.0"

lib/destroyed_at.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ def self.has_destroy_at?(object)
3030
module ClassMethods
3131
def destroyed(time = nil)
3232
query = where.not(destroyed_at: nil)
33-
query.where_values.reject! do |node|
33+
values = query.respond_to?(:where_clause) ? query.where_clause.send(:predicates) : query.where_values
34+
values.reject! do |node|
3435
Arel::Nodes::Equality === node && node.left.name == 'destroyed_at' && node.right.nil?
3536
end
3637
time ? query.where(destroyed_at: time) : query.where.not(destroyed_at: nil)

lib/destroyed_at/has_many_association.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,8 @@ def delete_records(records, method)
99
r.destroy
1010
end
1111
end
12-
update_counter(-records.length) unless inverse_updates_counter_cache?
12+
iucc = ActiveRecord::VERSION::MAJOR >= 5 ? reflection.inverse_updates_counter_cache? : inverse_updates_counter_cache?
13+
update_counter(-records.length) unless iucc
1314
else
1415
super
1516
end

0 commit comments

Comments
 (0)