Skip to content

Commit 66e37c7

Browse files
authored
deploy 1.13.5
배포 1.13.5
2 parents 7fda0b5 + e192bed commit 66e37c7

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

src/main/java/com/day_walk/backend/domain/review/controller/ReviewController.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,10 @@ public ResponseEntity<Map<String, Object>> getAllReviewByPlace(@RequestParam("pl
8484
@GetMapping("/all/total")
8585
public ResponseEntity<Map<String, Object>> getTotalByPlace(@RequestParam("placeId") UUID placeId) {
8686
GetReviewTotalDto reviewTotal = reviewService.getReviewTotal(placeId);
87-
boolean success = reviewTotal != null;
8887

8988
Map<String, Object> response = new HashMap<>();
90-
response.put("success", success);
91-
response.put("message", success ? "장소별 리뷰 통계 조회 성공!" : "장소별 리뷰 통계 조회 실패..");
89+
response.put("success", true);
90+
response.put("message", "장소별 리뷰 통계 조회 성공!");
9291
response.put("reviewTotal", reviewTotal);
9392

9493
return ResponseEntity.status(HttpStatus.OK).body(response);

src/main/java/com/day_walk/backend/domain/review/service/ReviewService.java

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -143,13 +143,15 @@ public GetReviewTotalDto getReviewTotal(UUID placeId) {
143143
throw new CustomException(ErrorCode.PLACE_NOT_FOUND);
144144
}
145145

146-
List<ReviewEntity> reviewList = getReviewEntityBean.exec(place);
147-
if (reviewList == null || reviewList.isEmpty()) {
146+
List<ReviewEntity> reviewList = Optional.ofNullable(getReviewEntityBean.exec(place))
147+
.orElse(List.of());
148+
149+
if (reviewList.isEmpty()) {
148150
return null;
149151
}
150152

151153
List<UUID> top5TagIds = reviewList.stream()
152-
.flatMap(review -> review.getTagList().stream())
154+
.flatMap(review -> Optional.ofNullable(review.getTagList()).orElse(List.of()).stream())
153155
.collect(Collectors.groupingBy(tagId -> tagId, Collectors.counting()))
154156
.entrySet().stream()
155157
.sorted((e1, e2) -> Long.compare(e2.getValue(), e1.getValue()))
@@ -159,11 +161,13 @@ public GetReviewTotalDto getReviewTotal(UUID placeId) {
159161

160162
List<TagEntity> topTags = top5TagIds.stream()
161163
.map(getTagEntityBean::exec)
162-
.collect(Collectors.toList());
164+
.filter(Objects::nonNull)
165+
.toList();
163166

164-
List<String> tagNames = getTagNameBean.exec(topTags);
167+
List<String> tagNames = Optional.ofNullable(getTagNameBean.exec(topTags)).orElse(List.of());
165168

166-
double stars = Math.round(getReviewStarsAvgBean.exec(reviewList) * 10) / 10.0;
169+
double starsRaw = getReviewStarsAvgBean.exec(reviewList);
170+
double stars = Math.round(starsRaw * 10) / 10.0;
167171

168172
return GetReviewTotalDto.builder()
169173
.reviewNum(reviewList.size())

0 commit comments

Comments
 (0)