-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
what about dark theme support? #35
Comments
not a real issue as the configuration will show the same effect by default for both dark and regular theme. It would be good to make it responds to common dark theme though |
Yeah, this feature is very needed, but I postponed it not to waste too much time on refining the visual part, focusing on the db and build system. We can sprinkle some "dark-..." classes everywhere to have the dark mode feature, but may be there's another way. I'm thinking of implementing some kind of theming. May be you have any ideas how to do that? 😄 |
Actually Anu seems to be a nice case! It uses the UnoCSS plugin system, which seems to be perfect for GunVue too. Need to explore this more. May be even integrate Anu as an underlying suitcase of basic components. |
Anu has dark theme support by default and do not need to add |
I played half day with |
Yeah! I'm just exploring it's docs and source to find ways to integrate into the components package. And still make them customizable. If you have a clue how to do it - please share ) |
Man, I just can't make it work with my current layered setup... How to manage styles not to be in need to build the components each time I need to check them in the app. |
current version is a bit old (0.12.0), they have |
I found need some options like below, it seems to be very flexible <ASelect optionsWrapperClasses="z-500"/>
<AInput type="number" input-wrapper-classes="px-0" /> |
Seems doable! Like so we need a prop of classes for each wrapper in a component. And so the initial classes can be stored in props default. But idk how UnoCSS handles that. Will see 👀 |
markdown with light/dark
|
I found it easy to work with anu by default if you do not set background color, or if you set a neutral color like |
your gun-avatar seems to support dark mode variable can get from @vueuse |
Good point! Yet in my experience it's better to have one isDark instance established somewhere and imported from all the places. I'll test your solution too. |
yes, expose from your ui or styles composable is better |
@lospringliu I've got you covered! Full dark mode support has landed with v.0.14.2! |
current rendering does not seem to fit dark mode well.
What about make some global update to make it work with something like https://anu-vue.netlify.app/guide/features/theme.html ?
this does not require to set configurations on a lot of places
The text was updated successfully, but these errors were encountered: