Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[79.9]TFC bottle not interacting with other mods #656

Open
Azaysol opened this issue Oct 26, 2014 · 5 comments
Open

[79.9]TFC bottle not interacting with other mods #656

Azaysol opened this issue Oct 26, 2014 · 5 comments

Comments

@Azaysol
Copy link

Azaysol commented Oct 26, 2014

TFC went from using the vanilla bottle in 1.6.4 to its own codded one in 1.7.10.
This is causing an issue with Railcraft since it wont fill up with other mods liquids it seems, in particular in this case it is Creosote Oil.

Forge- 1217
TFC- 79.9
Railcraft- 9.3.3.0

@Azaysol Azaysol changed the title TFC bottle not interacting with other mods [79.9]TFC bottle not interacting with other mods Oct 27, 2014
@aliceingame
Copy link
Contributor

I think that many issues can rise from having TFC specific items to replace vanilla.
Would there be a way to force TFC stacksize to vanilla items, something like what Thaumcraft does when it add essentia values to Vanilla items ?

@Kittychanley
Copy link
Collaborator

No. 1.7 made all vanilla items final, so TFC is no longer able to edit them. That's why so many things have their own TFC versions now.

@Azaysol
Copy link
Author

Azaysol commented Oct 28, 2014

is there a way to make this work?

@aliceingame
Copy link
Contributor

I do like the idea of size and weight of items in tfc, but If I had the choice, I would do two things

  • remove size from the tooltip and only keep it for the items that do not fit in chest like the minecart and sluice
  • create tfc version of vanilla items only if they should not stack to 64

pro

  • no need for tfc specific item
  • less line for translation
  • less textures
  • less compatibility problem
  • smoother integration of new mods in a modpack (as all items would not have the default items size tooltip)

con

  • remove a TFC specific feature

@Bletch1971
Copy link
Contributor

It might be possible to get the glass bottle to work with fluids from other mods if the glass bottle implemented the IFluidContainerItem.

Even if was changed to implement IFluidContainerItem, the other mod would need to handle the filling/draining of fluids from items that implement IFluidContainerItem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants