Skip to content

Commit a341bee

Browse files
committed
Merge branch 'develop'
* develop: Change README Implement changes for 5.1 Increment to 0.3.5 Fully support 5.0
2 parents eefd321 + ae3e4ac commit a341bee

File tree

4 files changed

+5
-11
lines changed

4 files changed

+5
-11
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ bin/kibana plugin -i health_metric_vis -u https://github.com/DeanF/health_metric
88
```
99
For Kibana 5:
1010
```bash
11-
kibana-plugin install https://github.com/DeanF/health_metric_vis/releases/download/v0.3.4/health_metric_vis-${KIBANA_VERSION}.zip
11+
kibana-plugin install https://github.com/DeanF/health_metric_vis/releases/download/v0.3.5/health_metric_vis-${KIBANA_VERSION}.zip
1212
```
1313

1414

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "health_metric_vis",
3-
"version": "0.3.4",
3+
"version": "0.3.5",
44
"kibana": {
55
"version": "{VERSION}"
66
},

public/health_metric_vis.js

+1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ function HealthMetricVisProvider(Private) {
3131
},
3232
editor: require('plugins/health_metric_vis/health_metric_vis_params.html')
3333
},
34+
implementsRenderComplete: true,
3435
schemas: new Schemas([
3536
{
3637
group: 'metrics',

public/health_metric_vis_controller.js

+2-9
Original file line numberDiff line numberDiff line change
@@ -55,18 +55,11 @@ module.controller('KbnHealthMetricVisController', function ($scope, Private) {
5555
});
5656
};
5757

58-
$scope.$watch('esResponse', function (resp) {
58+
$scope.$watchMulti(['esResponse', 'vis.params'], function ([resp]) {
5959
if (resp) {
6060
metrics.length = 0;
61-
$scope.esResponse = resp;
6261
$scope.processTableGroups(tabifyAggResponse($scope.vis, resp));
63-
}
64-
});
65-
66-
$scope.$watch('vis.params', function (val) {
67-
if ($scope.esResponse) {
68-
metrics.length = 0;
69-
$scope.processTableGroups(tabifyAggResponse($scope.vis, $scope.esResponse));
62+
$element.trigger('renderComplete');
7063
}
7164
});
7265
});

0 commit comments

Comments
 (0)