Skip to content

Inconsistency with new classes DeeplClient and DeeplClientOptions. #59

@VincentLanglet

Description

@VincentLanglet

Hi @JanEbbing

I saw you introduced a new DeeplClient classes which is supposed to be used instead of Translator.
cf 46b68a7

There is also a DeeplClientOptions class, but I don't see why it extends TranslateTextOptions.
Shouldn't it extends TranslatorOptions instead ?

In the same way I did

new Translator($apiKey, [TranslatorOptions::DEFAULT_MAX_RETRIES => 0])

i would expect now to do

new DeepLClient($apiKey, [DeeplClientOptions::DEFAULT_MAX_RETRIES => 0])

WDYT ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions