Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Unreviewed label is confusing and its timeline should improve #303

Open
elibarzilay opened this issue Jan 1, 2021 · 1 comment
Open

Comments

@elibarzilay
Copy link
Contributor

In case where am owner approval was given but a maintainer approval is needed, the code sees that there is no approval and goes into the unreviewed timeline and the Unreviewed label is obviously confusing. See for example DefinitelyTyped/DefinitelyTyped#50161 (which I captured to test when this is fixed).

@jablko
Copy link
Contributor

jablko commented Jan 1, 2021

approverKind !== "maintainer" would fix this? #254 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants