Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check delimiter for lists of files in mdu #662

Open
veenstrajelmer opened this issue Jul 4, 2024 · 0 comments
Open

Check delimiter for lists of files in mdu #662

veenstrajelmer opened this issue Jul 4, 2024 · 0 comments
Labels
type: compatibility Changes needed to be compatible with the computational core

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jul 4, 2024 •
edited
Loading

What is the need for this task.
For some file-keywords, there is delimiter=; set, like here:

HYDROLIB-core/hydrolib/core/dflowfm/mdu/models.py

Lines 1951 to 1953 in f234161

structurefile: Optional[List[StructureModel]] = Field(
None, alias="structureFile", delimiter=";"
)

In my experience, filepaths for obs/crs files are delimited with spaces. Are these indeed handled differently by the kernel, or not?

What is the task?
Check if the current hydrolib core delimiters are consistent with what the kernel expects.
@priscavdsluis priscavdsluis added the type: compatibility Changes needed to be compatible with the computational core label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: compatibility Changes needed to be compatible with the computational core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@priscavdsluis @veenstrajelmer