Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to meshkernelpy 5.0.0 #702

Open
veenstrajelmer opened this issue Sep 16, 2024 · 1 comment
Open

Update to meshkernelpy 5.0.0 #702

veenstrajelmer opened this issue Sep 16, 2024 · 1 comment

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Sep 16, 2024

What is the need for this task.
Major version of meshkernelpy was updated, hydrolib-core should be accomodated for this new version. It is the expectation that no code changes are needed.

What is the task?
Update maximum meshkernelpy version in pyproject.toml

Also, add testcase for DeleteMeshOption.FACES_WITH_INCLUDED_CIRCUMCENTERS

@veenstrajelmer
Copy link
Collaborator Author

veenstrajelmer commented Sep 16, 2024

Two testcases fail:

FAILED tests/dflowfm/test_net.py::test_create_clip_2d[0-False-22-68-13] - assert 30 == 22
FAILED tests/dflowfm/test_net.py::test_create_clip_2d[1-False-30-98-20] - assert 22 == 30

Reported in Deltares/MeshKernelPy#189. It can be easily solved by switching the expected values, but the new deletion behavior is counter-intuitive and might be a breaking change for some users. Therefore, this should be considered carefully. In my view, the best way to move forward is patching meshkernel(py) by reverting the deletion behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant