Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inventorize koswat acceptance tests #179

Open
1 of 7 tasks
ArdtK opened this issue Oct 21, 2024 · 0 comments
Open
1 of 7 tasks

Inventorize koswat acceptance tests #179

ArdtK opened this issue Oct 21, 2024 · 0 comments
Labels
documentation Improvements or additions to documentation question Further information is requested

Comments

@ArdtK
Copy link
Contributor

ArdtK commented Oct 21, 2024

Kind of request

Modifying existing functionality

Enhancement Description

Inventorize the existing acceptance / system tests in order to avoid redundancy. For this purpose we propose to create a test plan covering the following aspects:

  • Describe current acceptance tests (goal, configuration, validations) #223
  • Definition of acceptance tests.
    • Where are they placed?
    • Do they require a special category instead of being in TestAcceptance?
    • Which data do they use to run?
    • Who maintains said data?
  • Determine scope to test:
    • Generation of reinforcement profiles? Currently not considered as acceptance tests as they run "fast".
    • "Sandbox" Koswat analysis (WITHOUT validation of expected results, only checks generation of files), for the default input profile and the following combination of cases:
      • With / without infrastructure,
      • With / without obstacles,
      • With / without grass and clay layer,
      • With Scenario default / 2 / 3
    • "Sandbox" Koswat analysis (WITH validation of expected results), default scenario, with obstacles and the combination of:
      • With / without grass and clay layer,
      • With Scenario default / 2 / 3
      • This test category should be replaced with a "curated" approach of the previous one.
    • "Sandbox" Koswat analysis with default layers, and all possible input profiles, checks for the correct generation of the reinforcement profiles.
    • The very first acceptance tests might be outdated / redundant as per now, study whether we should keep them in a small test-case or remove them instead:
      • TestKoswatHandler.test_koswat_handler_run_analysis_given_valid_data
      • tests.test_main.TestMain.test_given_valid_input_succeeds
  • Update test bench according to what's spoken in the previous step.
  • Study the option of delivering a docker version of the tool that can be used to run koswat via command line.

Use case

Product owner as well as developers want to understand what are we currently testing and verify whether the generated results adhere to domain expectations.

Both PO and dev team should be able to modify / extend the test data that will be collected by the acceptance tests without having to create new tests (or modifying the existing ones). This would enable testers / domain experts / PO to easily validate the current status of the tool.

Additional Context

  • @peterdgr Describe needs
  • Create the required subissues from this one.
@ArdtK ArdtK added this to the Sprint 2024.4.2 milestone Oct 21, 2024
@Carsopre Carsopre added documentation Improvements or additions to documentation question Further information is requested labels Oct 23, 2024
@Carsopre Carsopre changed the title Validate koswat acceptance tests Inventorize koswat acceptance tests Oct 30, 2024
@ArdtK ArdtK self-assigned this Nov 7, 2024
@ArdtK ArdtK linked a pull request Nov 7, 2024 that will close this issue
6 tasks
@ArdtK ArdtK removed a link to a pull request Nov 11, 2024
6 tasks
@ArdtK ArdtK removed their assignment Nov 11, 2024
@ArdtK ArdtK removed this from the Sprint 2024.4.2 milestone Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants