Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert connectivity variable data from file's start_index convention to caller-preferred start_index. #12

Open
arthurvd opened this issue Apr 25, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@arthurvd
Copy link
Member

Is your feature request related to a problem? Please describe.
The UGRID topology tables (e.g. face_nodes) contain the integer index references as they occur in the input file read, with the start_index convention used in that same file. A calling application might want to use different 0/1-based indexing, so it would be nice to be able to pass a caller's start_index to request that when calling mesh2d.get*-like functions.

Describe the solution you'd like
I don't know yet which API function(s) are the best to receive such an extra input argument.
But, the given start_index must be used to convert the index values read from file, as it was also done in the predecessor ("io_netcdf").

It is important to respect any _FillValue present in the file: missing values must not be shifted by +/-1.

Describe alternatives you've considered
Let the client do this itself. A bit less user-friendly.

Additional context
See issue #3, which must be finished before this issue can be picked up.

@arthurvd arthurvd added the enhancement New feature or request label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant