Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong equation for residual moisture content seems to be used #285

Open
2 tasks done
jensdebruijn opened this issue Aug 14, 2024 · 1 comment · May be fixed by #300
Open
2 tasks done

Wrong equation for residual moisture content seems to be used #285

jensdebruijn opened this issue Aug 14, 2024 · 1 comment · May be fixed by #300
Assignees
Labels
bug Something isn't working needs refinement issue still needs refinement

Comments

@jensdebruijn
Copy link

jensdebruijn commented Aug 14, 2024

HydroMT-Wflow version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of HydroMT-Wflow.

Reproducible Example

Current behaviour

The function in hydromt-wflow

def thetar_toth(oc, clay, silt):
states that the residual moisture content is estimated, but the used equation is actually for the wilting point. See S1 of https://bsssjournals.onlinelibrary.wiley.com/doi/full/10.1111/ejss.12192.

image

Desired behaviour

Additional context

No response

@jensdebruijn jensdebruijn added bug Something isn't working needs refinement issue still needs refinement labels Aug 14, 2024
@jensdebruijn jensdebruijn changed the title Wrong equation seems to be used Wrong equation for residual moisture content seems to be used Aug 14, 2024
@verseve
Copy link
Member

verseve commented Oct 8, 2024

Thanks for reporting this issue.

This is indeed the equation for the wilting point. @RubenImhoff: do you perhaps know why this equation was selected for residual water content? I guess for coarse textured soils this equation is most probably fine, but for fine textured soils it may overestimate residual water content. In the Toth paper theta_r is estimated based on only sand content (RT method). Additionally, we also used a PTF of Rawls and Brakensiek to estimate theta_r (as part of Python scripts before hydromt_wflow).

Would be good to look into this further and decide if we need to replace this equation. Furthermore, would be good to discuss if we want to support different PTFs (probably also concerns other parameters like theta_s).

@verseve verseve self-assigned this Oct 11, 2024
@verseve verseve linked a pull request Oct 13, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs refinement issue still needs refinement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants