Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapbox_earcut is broken for numpy 2.0 #264

Open
Huite opened this issue Jul 22, 2024 · 2 comments
Open

mapbox_earcut is broken for numpy 2.0 #264

Huite opened this issue Jul 22, 2024 · 2 comments

Comments

@Huite
Copy link
Collaborator

Huite commented Jul 22, 2024

For both pypi and conda.

There's a conda-feedstock PR in progress. Since the problem seems to be resolved by rebuilding with pybind against numpy 2.0, I'm optimistic that this can be resolved relatively quickly.

However, the PR for the mapbox_earcut Python bindings to regenerate the wheels requires the original maintainer to publish the wheels on pypi. This might mean that in some time, the conda-forge bindings will work with numpy 2.0, but the pip installed one won't. We can either:

  • pin to numpy < 2
  • make mapbox_earcut an optional dependency, which isn't installed via pypi.

Both are not ideal, but my expectation is that most use is through conda-forge.

Another note: the optional dependency approach will just result in an import error, which one would expect to solve by simply running pip install mapbox_earcut. This will then result not in a crash, but nonsense results. So then we'd have to run a check on version numbers...

Or alternatively, with a little patience both the wheels and the conda-forge release are updated for numpy 2.0 and no effort is required.

@JoerivanEngelen
Copy link
Contributor

Update: mapbox_earcut_python has just released an update 2 days ago, supporting numpy 2. https://github.com/skogler/mapbox_earcut_python/releases/tag/v1.0.2

When the feedstock is also merged, we can move to numpy 2.

@Huite
Copy link
Collaborator Author

Huite commented Oct 7, 2024

Seems to be fixed some time ago for the feedstock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants