Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an option to process all comments #81

Open
Alhaitham opened this issue Jan 26, 2023 · 5 comments · May be fixed by #85
Open

Adding an option to process all comments #81

Alhaitham opened this issue Jan 26, 2023 · 5 comments · May be fixed by #85
Labels
enhancement New feature or request

Comments

@Alhaitham
Copy link

Hello

Sometimes there are a lot of deleted or edited comments on a page

So instead of doing it one by one, it would be great if the is an option to do it all

There are websites that do it like unddit and reveddit, but doing it on reddit would be better

Thanks

@DenverCoder1 DenverCoder1 added the enhancement New feature or request label Jan 26, 2023
@DenverCoder1
Copy link
Owner

Possible ideas include:

  • Add the option to a popup menu when clicking the extension icon
    • pros: this will be intuitive enough for most users and not get in the way
    • cons: this won't work for the userscript version; only the browser extension
  • Add a keyboard shortcut for activating the feature
    • pros: does not get in the way
    • cons: some users may not be able to remember the shortcut
  • Add a floating button on the page
    • pros: works with extension and userscript and will be easily noticable
    • cons: can get in the way of other elements, some users who don't use it may find it annoying
  • Add a small link in the corner
    • pros: works with extension and userscript and does not get in the way
    • cons: might not be easily noticed

Maybe a combination of different methods could be used. What do you think would be the best approach for this?

@Alhaitham
Copy link
Author

The last one seems reasonable, it can be placed maybe under OP

@Alhaitham
Copy link
Author

Also hope that it will show deleted comments that are not visible in the page

When there is no indication of the comment being there

@DenverCoder1
Copy link
Owner

The last one seems reasonable, it can be placed maybe under OP

That sounds reasonable, currently I have an implementation that adds a link by the parent post and also has a keyboard shortcut. If you're interested in testing it and giving feedback that would be great, let me know. (see #85)

Also hope that it will show deleted comments that are not visible in the page
When there is no indication of the comment being there

While it sounds useful, I feel that is out of the scope of the project for now. Determining which comments were deleted/removed using info from the Pushshift and Reddit APIs and determining positions in the comment tree for placing the comments is a complicated problem that would likely take a significant amount of time to implement. Feel free to open a separate issue for that feature, but as of now, I think a simpler approach would be to just create a link to an external site such as unddit.com if that's what you're looking for.

@Alhaitham
Copy link
Author

Alhaitham commented Jan 27, 2023

Feel free to open a separate issue for that feature

Here

#86

I think a simpler approach would be to just create a link to an external site such as unddit.com if that's what you're looking for.

Already using two userscripts but thought it would be better to be less reliant on external sites

https://greasyfork.org/en/scripts/435980-reddit-add-unddit-links
https://greasyfork.org/en/scripts/435978-reddit-add-reveddit-links

If you're interested in testing it and giving feedback that would be great, let me know.

It is working fine for topics

It is also showing on the first topic when viewing a subreddit

When clicking on it, it shows the first edited topic from the list, and does nothing if there was no edited topic

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants