Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dataset option in GFD during python integration #341

Open
Mstrutov opened this issue Jan 17, 2024 · 0 comments
Open

Change dataset option in GFD during python integration #341

Mstrutov opened this issue Jan 17, 2024 · 0 comments

Comments

@Mstrutov
Copy link
Collaborator

The reason we have a separate option Table for CSV tables is because the table can be specified for the algorithm not only as path, but also as pandas dataframe. So what we need to think about here is how do we want to specify input graphs from python, if using path to the file, then storing only path is ok.
Since in this PR we're not touching python bindings at all, there is little reason to create a separate option, and we can just store paths for simplicity. So IMO the separate option, if required, should be added in the future along with python bindings.

Originally posted by @polyntsov in #154 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant