Merge pull request #1373 from agn-7/fix/security-install-agents-audit

fix(security): audit shared agent skills

Author: DeusData

scripts/security-install.sh

@@ -49,13 +49,15 @@ find "$HOME" -type f > "$TMPDIR/created_files.txt" 2>/dev/null || true
 # Expected path patterns (relative to HOME):
 #   .config/*/mcp.json (or .mcp.json variants)
 #   .claude/skills/*
+#   .agents/skills/*
 #   .claude/settings.json
 #   .continue/config.yaml
 #   .codeium/config.json
 #   .local/bin/codebase-memory-mcp
 #   Various agent config dirs
 
 EXPECTED_PATTERNS=(
+    ".agents/"
     ".claude/"
     ".cursor/"
     ".config/"
@@ -121,10 +123,18 @@ fi
 echo ""
 echo "--- Auditing skill file content ---"
 
-SKILLS_DIR="${CLAUDE_CONFIG_DIR:-$HOME/.claude}/skills"
-if [[ -d "$SKILLS_DIR" ]]; then
-    SKILL_ISSUES=0
+SKILL_DIRS=(
+    "${CLAUDE_CONFIG_DIR:-$HOME/.claude}/skills"
+    "$HOME/.agents/skills"
+)
+SKILL_ISSUES=0
+SKILL_DIRS_FOUND=0
 
+for SKILLS_DIR in "${SKILL_DIRS[@]}"; do
+    if [[ ! -d "$SKILLS_DIR" ]]; then
+        continue
+    fi
+    SKILL_DIRS_FOUND=1
     while IFS= read -r skill_file; do
         basename=$(basename "$skill_file")
 
@@ -138,24 +148,26 @@ if [[ -d "$SKILLS_DIR" ]]; then
         done
 
         # Check for unexpected URLs
-        if grep -oE 'https?://[^\s"'"'"']+' "$skill_file" 2>/dev/null | grep -v 'github.com/DeusData' | grep -v 'localhost' | grep -v '127.0.0.1' > /tmp/sec_skill_urls 2>/dev/null; then
+        if grep -oE 'https?://[^\s"'"'"']+' "$skill_file" 2>/dev/null | grep -v 'github.com/DeusData' | grep -v 'localhost' | grep -v '127.0.0.1' > "$TMPDIR/sec_skill_urls" 2>/dev/null; then
             while IFS= read -r url; do
                 echo "REVIEW: Skill '$basename' contains URL: $url"
-            done < /tmp/sec_skill_urls
-            rm -f /tmp/sec_skill_urls
+            done < "$TMPDIR/sec_skill_urls"
+            rm -f "$TMPDIR/sec_skill_urls"
         fi
 
         # Check for encoded strings (base64-like blocks > 50 chars)
         if grep -E '[A-Za-z0-9+/]{50,}={0,2}' "$skill_file" > /dev/null 2>&1; then
             echo "REVIEW: Skill '$basename' contains potential encoded content"
         fi
     done < <(find "$SKILLS_DIR" -type f -name '*.md')
+done
 
+if [[ $SKILL_DIRS_FOUND -eq 0 ]]; then
+    echo "SKIP: No skills directory created."
+else
     if [[ $SKILL_ISSUES -eq 0 ]]; then
         echo "OK: Skill files contain no dangerous patterns."
     fi
-else
-    echo "SKIP: No skills directory created."
 fi
 
 # ── Summary ──────────────────────────────────────────────────────