Syntax module: highlighting should not focus editor if it's not focused (T1248083) (#132)

Author: ksercs

modules/syntax.js

@@ -238,7 +238,7 @@ class Syntax extends Module {
       container.highlight(this.highlightBlot, force);
     });
     this.quill.update(Quill.sources.SILENT);
-    if (range != null) {
+    if (range != null && this.quill.hasFocus()) {
       this.quill.setSelection(range, Quill.sources.SILENT);
     }
   }

test/unit/modules/syntax.js

@@ -287,6 +287,17 @@ describe('Syntax', function () {
       );
     });
 
+    it('should not call selection change if editor is not focused to not refocus (T1233316)', function () {
+      this.quill.setSelection(1, 1);
+      this.quill.root.blur();
+
+      const setSelectionSpy = spyOn(this.quill, 'setSelection');
+      this.quill.getModule('syntax').highlight();
+
+      expect(setSelectionSpy).not.toHaveBeenCalled();
+      setSelectionSpy.calls.reset();
+    });
+
     describe('allowedChildren', function () {
       beforeAll(function () {
         SyntaxCodeBlock.allowedChildren.push(BoldBlot);