Selection: prevent scrolling when focusing root (T1297029) (#141)

Author: ksercs

core/selection.js

@@ -86,7 +86,7 @@ class Selection {
 
   focus() {
     if (this.hasFocus()) return;
-    this.root.focus();
+    this.root.focus({ preventScroll: true });
     this.setRange(this.savedRange);
   }
 
@@ -318,7 +318,7 @@ class Selection {
     const selection = document.getSelection();
     if (selection == null) return;
     if (startNode != null) {
-      if (!this.hasFocus()) this.root.focus();
+      if (!this.hasFocus()) this.root.focus({ preventScroll: true });
       const { native } = this.getNativeRange() || {};
       if (
         native == null

test/unit/core/selection.js

@@ -41,6 +41,24 @@ describe('Selection', function () {
     });
   });
 
+  describe('focusing should not trigger scroll', function () {
+    beforeEach(function () {
+      this.initialize(HTMLElement, '<div></div>');
+      this.selection = this.initialize(Selection, '<p>0123</p>', this.container);
+      spyOn(this.selection.root, 'focus').and.callThrough();
+    });
+
+    it('on focus method call (T1297029)', function () {
+      this.selection.focus();
+      expect(this.selection.root.focus).toHaveBeenCalledOnceWith({ preventScroll: true });
+    });
+
+    it('on setNativeRange method call', function () {
+      this.selection.setNativeRange(this.container.firstChild, 0);
+      expect(this.selection.root.focus).toHaveBeenCalledOnceWith({ preventScroll: true });
+    });
+  });
+
   describe('getRange()', function () {
     it('empty document', function () {
       const selection = this.initialize(Selection, '');