Table format: support insert of multiline text to cell (T1086552) (#47)

Author: ksercs

.github/workflows/functional-tests.yml

@@ -16,7 +16,7 @@ jobs:
     - name: Use Node.js
       uses: actions/setup-node@v2
       with:
-        node-version: 'lts/*'
+        node-version: '15'
     - run: sudo apt-get install xvfb
     - run: npm ci
     - run: npm run build

.github/workflows/unit-tests.yml

@@ -21,7 +21,7 @@ jobs:
     - name: Use Node.js
       uses: actions/setup-node@v2
       with:
-        node-version: 'lts/*'
+        node-version: '15'
     - run: sudo apt-get install xvfb
     - run: npm ci
     - run: npm run build

formats/table/index.js

@@ -53,6 +53,11 @@ class CellLine extends Block {
   }
 
   format(name, value) {
+    const isCellLine = name === 'tableCellLine';
+    if (isCellLine && value === null) {
+      value = this.formats().tableCellLine;
+    }
+
     const isCell = CELL_IDENTITY_KEYS.indexOf(name) > -1;
     if (isCell || TABLE_FORMATS[name] || CELL_FORMATS[name]) {
       const attrName = `data-${isCell ? 'table-' : ''}${name.toLowerCase()}`;

test/unit/modules/table_main.js

@@ -751,9 +751,26 @@ describe('Table Module', function() {
     });
 
     it('insertText before', function() {
-      this.quill.updateContents(new Delta().insert('\n'));
+      const tableHTML = `
+        <br>
+        <table>
+          <tbody>
+            <tr><td>a1</td><td>a2</td><td>a3</td></tr>
+            <tr><td>b1</td><td>b2</td><td>b3</td></tr>
+          </tbody>
+        </table>
+      `;
+      this.quill = this.initialize(Quill, tableHTML, this.container, {
+        modules: {
+          table: true,
+        },
+      });
+
+      this.quill.updateContents(new Delta().insert('\nBefore Line\n'));
       expect(this.quill.root).toEqualHTML(
         `
+          <p><br></p>
+          <p>Before Line</p>
           <p><br></p>
           <table>
             <tbody>
@@ -774,6 +791,35 @@ describe('Table Module', function() {
       );
     });
 
+    it('insert multiline text to cell (T1086552)', function() {
+      this.quill.updateContents(
+        new Delta().retain(8).insert('\nLine 1\nLine 2'),
+      );
+      expect(this.quill.root).toEqualHTML(
+        `
+          <table>
+            <tbody>
+              <tr>
+                <td><p>a1</p></td>
+                <td><p>a2</p></td>
+                <td>
+                  <p>a3</p>
+                  <p>Line 1</p>
+                  <p>Line 2</p>
+                </td>
+              </tr>
+              <tr>
+                <td><p>b1</p></td>
+                <td><p>b2</p></td>
+                <td><p>b3</p></td>
+              </tr>
+            </tbody>
+          </table>
+        `,
+        true,
+      );
+    });
+
     it('insertText after', function() {
       this.quill.updateContents(new Delta().retain(18).insert('\n'));
       expect(this.quill.root).toEqualHTML(