-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatpak version #1199
Comments
I'd love to see this as well. There are distros out there like Fedora Silverblue where Flatpaks are the preferred method of app delivery. |
Agreed. Alternatively, an AppImage would be fine too. |
This way all Linux distros would be able to easily use this software |
Flatpak is not a bad idea as the GirCore binaries are build to match the flatpak binaries. This avoids missing dependencies and libraries which are named differently than the flatpak ones. |
Hi there, If I base myself on the DEB package, I have a
DevToys should be installed in Let's say the built binaries of DevToys, ready to be packed, are in I'm not finding a clear answer on how to include the 2 dependencies I mentioned above. I'm also confused by the Much appreciated! |
I have not done it myself but there are already dotnet applications being distributed via flatpak:
I would recommend comparing both ways to understand things (I have not done this myself yet). But i think it should get you started. Additionally one day I found this on github: https://github.com/flathub/org.freedesktop.Sdk.Extension.dotnet8 I did not check it out in detail but perhaps it helps. Im regard to libadwaita and webkitgtk: if you target the gnome runtime sdk in its current release 46 (this is what GirCore 0.5.0 is build for) it should just be available. See for example the Epiphany flatpak the GNOME web browser which uses both libraries. |
One more thing: I don't know how it will work with extensions. There would probably be rights needed to access the home directory but if this is sufficient I don't know. |
@veler You can take a look at https://docs.flatpak.org/en/latest/conventions.html. Flatpak expects a few conventions. The Flatpak manifest doesn't only define where to install the application, but also how to build it. It should contain build instructions for the application. Dependencies are also usually built from source in the manifest. But maybe they're on the GNOME runtime already? https://docs.flatpak.org/en/latest/available-runtimes.html @badcel Thanks for the links. I have experimented a bit with Flatpak in the past, but didn't get to the point of publishing anything. I have zero experience with .NET, that's what hinders me a bit here... |
Thanks @hockdudu . I will read this later today. Maybe it's already explained there but I will ask in case: what if the app is already built? I basically have all the binaries in a folder, ready to be packed in zip, Deb...etc |
@veler You could use pre-built binaries, but AFAIK Flathub only allows binaries in exceptional circumstances. That's for auditing / safety reasons. By using sources, you can be sure the package doesn't do anything it shouldn't. With binaries, on the other hand, someone could have tampered it and added additional stuff (malware and the like). See https://docs.flathub.org/docs/for-app-authors/requirements#best-practices |
Just to make it clear : are we talking about building the source code on the user machine, or in my CI ? If the first, that sounds horrible. To run, DevToys had no dependencies needed outside of the 2 I mentioned earlier. But to build, it needs NodeJS,.NET, a total of 3 repositories... That will quickly cluter the user's machine. |
Neither ;) If submitted to Flathub, the code is built by Flathub themselves. You provide only the manifest and some metadata. Well, you build locally as well for testing, but the productive package is done by their Buildbot. You can look into repositories for popular apps: https://github.com/orgs/flathub/repositories?q=sort%3Astars The application is packaged by them and the end-user receives only the binaries. No clutter :D I looked into a few repositories, and I've noticed many are based off on You could probably look at e.g. https://github.com/flathub/com.visualstudio.code/blob/master/com.visualstudio.code.yaml for an example of an app built using But as stated previously, I experimented with Flatpak a little bit, but I'm no package maintainer or anything. Do also write to the folks at the Matrix chat https://matrix.to/#/#flatpak:matrix.org, they can also help out on the whole process. |
So, out of curiosity, I have experimented with creating a functional Flatpak manifest for DevToys. The results can be found in the attached archive. First of all, I'm not an active maintainer of any Flatpak. I just wanted to experiment with packaging this app. And while it is a good starting point, it needs more improvements before it could be submitted to Flathub. The archive contains a Flatpak manifest, which can, in theory, build the DevToys application from source and package it as a Flatpak. However, there are a few caveats: Firstly, Flatpak Builder pulls the dependecies before building, and then runs the build without a connection. AFAIK this is done to improve security and audibility of an Flatpak package. However, this means dependencies need to cached by Flatpak Builder and the build tools need to use that cache. Thanks to some tooling from the Flatpak team, creating that cache is quite straightforward. The archive contains a index used by Flatpak Builder to cache the required packages, and the commands to update this index can be found in the Readme. But this means also that I had to patch the build process to point towards said cache, so that Dotnet can build the app inside the build sandbox. Ideally, this patch should make it's way upstream as a build option. Secondly, the archive also contains a Lastly, while I technically have a build Flatpak with the DevToys application, it does not work right now. The application does not start, due to it missing some file. I suppose though this is because I'm not running the build or install as expected by DevToys.1 Finally, heres the archive for the Flatpak. Footnotes
|
A few further notes: But I'm not sure why this happens. @veler, it would help if you could provide some information on how you build the existing Linux releases, especially the portable zip. Might show why it expects the Footnotes |
Managed to find why the app didn't want to start in the Flatpak. Removing the With that, I now have a functional Flatpak manifest for DevToys: Here is the archive with the manifest. In my view, the contents in the archive should be sufficient for submission to Flathub. A few things to note:
|
Sorry for my lack of responsiveness here. Quite busy with many things this summer! @CodedOre, this is impressive to me, and I have many interogation as Flatpak is still quite obscure to me. Thank you very much for exploring all this though! I really appreciate !
That is interesting. I do not expect this file to be generated when using Here is what I use in the CI I made (which is different that
And then I delete |
Thanks for the reply, @veler! Since I haven't much experience with .net, I have based the Flatpak Build on the The build command Flatpak Builder currently uses is this one: ./build.sh --configuration Release --target PublishApp The
I see. AFAIK this is more or less the same as with what NUKE eventually runs. But it may make sense to only run I will look into this later this day. If you have other questions about the Flatpak build, just ask away. |
Thank you :) I guess, it would certainly help (with flatpak and other...) if I was publishing the CI on GitHub. The reason I kept it private is to try to deter some people from taking DevToys, which is under MIT license, and sell it without any significant change (it's something I saw happening in the past). Hoping that not publishing the CI would hide away the little details on how to publish the app smoothly.
Oh I see where it's used now ! Note that the CI I currently have privately also takes care of restoring nuget packages, node modules and Monaco Editor, and build DevToys.Tools properly. |
Well, in would be possible to build the Flatpak from a build output. You could take the output folder as directory source and only run the install commands with Flatpak Builder. 1 However, it also makes it less reproduceable and auditable, as it would basically take an unknown source with binary files. As the Flathub docs state:
If a distribution of a pre-build binary is wanted, the source would probably need to be publicly accessible, like the portable zip from the releases. Footnotes
|
I see. Building from the source might not be ideal in my case though, because the build process for release isn't as straight forward as it may sound like.
Perhaps I misunderstand this. The portable ZIP and what the Also, are we talking about building DevToys on the customer machine in order to install Flatpak? Sorry for the confusion 😅 |
The user does not need to build the Flatpak on his machine. In most cases, Flathub builds the Flatpak from the manifest on its own infrastructure on buildbot.flathub.org. Some, like OBS or Firefox, are build on their own CI's, with the Flatpak then published to Flathub. The user then downloads and installs the package. However, the manifest is publicly accessible. If you open any app on Flathub, you can find a link to the manifest file and check how its packaged, and could be audited on the package process. Also, when submitting a new application, the manifest will be reviewed by the Flathub team. Now, Flathubs policy is to prefer all components being build from source, if possible. It is possible to tell Flatpak Builder to use a archive of pre-buils binaries to create the package, which is what most proprietary and some unverified apps are doing. This is less auditable (as they are binaries), but generally accepted by the Flathub team. Still, this needs a accessible location from where to pull the binaries. Which is why I mentioned the portable zip. If a binary distribution is preferred, it would make most sense to use this as source for the Flatpak package. On a personal note: I choose to build from source because I generally like transparency over an build process, and also because just packaging the binaries wouldn't been a interesting challenge ;-) But I could create a manifest which just packages the release archive. As a bit of a sidenote, on how Flatpak Builder works: Flatpak Builder first downloads the sources to an cache, found in the folder When the Flatpak is run, this There are a few expectations on how the |
Alright, so I updated the manifest to use the publish command directly. I also found a way to update the nuget sources to the Flatpak-provided cache, so no patches are required anymore. Here is the archive with the updated manifest: DevToys-Source-Flatpak.zip. Also, I created a second manifest which takes the pre-compiled binaries from the Github Releases, for comparison: DevToys-Archive-Flatpak.zip |
Ooh, that makes more sense now! Thank you for the long explanation! I totally get why it's better to build it from the source in this scenario then! :D I haven't look at the manifest, I will try to do that tonight. Assuming it looks good, what next step would you recommend? |
I have found a bug, introduced when switching from using the Build project to using the dotnet commands directly, as it does display the wrong version: I noticed that there is a Then, there is the question of the contents in the This folder currently includes a copy of the icons in the folder structure Linux expects, the Desktop file and the Appstream file. As the Flathub docs states:
So, the question is if they could be brought upstream. When those points are resolved, I think the next step would be submitting the app. The submission process is outlined in this document. But it would mostly mean that the files from my archive would be submitted via an Merge Request on the Flathub repository. Lastly, there are a few steps to verify the Flatpak as official. In the case of DevToys, this would mean you getting a key from Flathub and storing it in a specific location on your website. Flathub would then use the key to verify that the Flatpak is official. The instructions for that process are located here. That's basically it! |
Ah! Yes! I forgot that... In the CI I made, we also set the version number in some files (and the syntax of it varies). Here is the steps the CI performs:
Ultimately, and based on my understanding of your previous explanation, a good thing to try would be to:
How does that sound?
I'm not sure what they expect. Is the Thanks for sharing your next step! Hopefully I can automate that more with the CI. Currently, I upload the generated packages to GitHub Release manually from each OS (Windows, Mac, Linux), publish an update on Microsoft Store, Homebrew and Winget manually, and soon I will add Chocolatey, and now Flatpak. It starts to add up 😅 |
That would sound good.
In most cases, it is the GitHub repository of the app. However, even a additional repository in the DevToys organization is likely fine. AFAIK, the main point behind this policy is to ensure that the information in the data files, especially the Appstream file, matches the other distributions of the app.
Well, submission and verification are steps you only need to do once. Though updates to the manifest remains a thing. |
I do have to ask: |
Yes it is. It's a NUKE build. I should probably not use the CI term in here. I understand myself 😅. |
I see. Then I should revert to use the One thing I noticed: Reason is: As mentioned before, the Appstream file is used by the Flathub website and Linux software centers to display information about the app. This also involves informations about releases and the changelog (Check the contents of the |
No, I do that manually before running the CI. Example: 1c60b39 |
Alright, so the Appstream file will just have to be updated manually. I have today looked again at using the NUKE
All these observations are based on the build system as it can be run from the Footnotes
|
@veler, how do you want to proceed with this? I see three options for this:
Since there are multiple options, you would need to decide which option to take. |
Hello @CodedOre :) Sorry for the late reply. The unpublished part should not be needed unless you want to publish the binaries on Apple Store or Microsoft Store. With this, my suggestion is to edit that CI to add some logic for the flatpak. There may be a bit of refactoring needed. I do admit that the code in this repository is literal garbage compared to I'd be happy to help integrating the flatpak to this. You seem to be advanced on the topic now. I'm also happy to let you draft a PR at your own rhythm. Please let me know what you prefer and how I can help :) Thank you again for everything! |
Thanks for publishing the CI, @veler. I will look at adding the Flatpak part in the coming days. |
Alright, to give an update: I have looked at the CI, and unfortunately, the refactoring required would be more than just "a bit"... Let's just go through to the ideas I tried in the last few days: 1. Adding Flatpak to the CI The idea here was to add code to the CI to package the compiled program in a Flatpak and publish this to Flathub. I did talk today with a few Flathub maintainers over on the Flathub Matrix room, and this seems to be an unlikely option. While some apps are build from external CI's, these are "exceptions for well-known projects". And it was highly recommended to use the normal submission process. Apart from that, running Flatpak Builder inside the NUKE build environment proved to be surprisingly difficult... So, I would drop this idea. 2. Running the CI inside Flatpak Builder The idea here was to run the NUKE build system inside Flatpak Builder. Well, this would need some major refactoring. Especially when looking at the All of these are points that make it difficult to run it in the environment of Flatpak Builder. And this is ignoring the fact that it is relatively bloated, building every step and multiple arches, and even the build system on each run... So, where does this leaves us? I would suggest on of two options: Option 1: Rework building entirely As one of the Flathub maintainers put it:
I can't speak much about how this would look for Windows or Mac, but for Linux packaging, especially Flatpak, the ideal case would be an build system that can use pre-loaded dependencies and then builds offline. The build would then be started from the packaging software. The last DevToys-Source-Flatpak archive already does this in most parts by ignoring the NUKE build. What's basically missing is a script handling the versioning update. Option 2: Just package an existing release Alternatively, we could just use the solution in the DevToys-Archive-Flatpak archive, use the released archives and package this. Not ideal, but better than trying to package the Flatpak inside the NUKE CI. So, that's for the update. |
I still did not look it up myself but for example Nickvionapps are Gir.Core based apps wich are packaged on flathub. Perhaps it helps to get started. I myself started to use F# and it's script files as build system in combination with the |
The Nickvision apps use the Cake build system. And more importantly, don't have the build system adapting the version number on build...
That sounds good. I think changing the version and splash screen updates to a F# script that can be run without the NUKE build would resolve that part of the issue. Will look at this later today. |
Hello, Thanks for your follow up. :) I appreciate the time you spent on that. Argh. Yeah this is tough. I wasn't aware that connecting to the internet would be an issue. See, this Question: From what I was understanding, Flatpak packaged are being installed by building sources on a local machine. That requires all the sources to be present. Is it a bad thing that a few files are being changed on the fly so they have the right version number? For the things downloaded from the internet, it "could" be avoided through a setting in the command line that makes skipping the part where we run the Also, I realize the Publish pipeline contains a bunch of Windows-specific binaries, which makes this quite dirty for Linux. Really, it's NOT designed to be shipped to end users. We'd indeed need to rewrite the whole publication pipeline just to take consideration of Flatpak. I'm also not super fan of the second option because a bunch of currently manual steps would need to be done. My ultimate wish / desire for the future is it have a 1-click CI that does everything, including creating the pull requests to update Homebrew and WinGet packages, pushes the MSIX to the MS Store...etc (which I currently do manually, and it takes quite some time), and include Flatpak in all this. |
Not really. They are build before-hand, but in the case of Flathub, they are build by an CI externally of the project.
While it is, unconventional, it in itself should not be that problematic from a technical perspective. The main issue is that these steps are tied to the pipeline, which also includes a lot of steps not working well inside Flatpak Builder (e.g. downloading while building).
The second option I've mentioned would just mean that the Flatpak manifest would load the released binaries from GitHub and package it, so I'm not sure about the "manual steps" you're concerned about. If its about updates, we can add parameters to the manifest which will tell the Flathub CI to automatically check for an update and prepare the changes needed to the manifest in an pull request. Its still not fully automatic, but manageable. |
What feature or new tool do you think should be added to DevToys?
Flatpak version of the app.
Why do you think this is needed?
Easy installation on Linux distros with more compatibility.
Solution/Idea
No response
Comments
No response
The text was updated successfully, but these errors were encountered: