Skip to content
This repository has been archived by the owner on Jul 19, 2022. It is now read-only.

[i18n]: seems some paragraph missing from src #51

Open
seognil opened this issue Dec 24, 2019 · 3 comments
Open

[i18n]: seems some paragraph missing from src #51

seognil opened this issue Dec 24, 2019 · 3 comments
Labels

Comments

@seognil
Copy link
Contributor

seognil commented Dec 24, 2019

e.g.

Destructuring
The destructuring assignment syntax is a JavaScript expression that makes it possible to unpack values from arrays, or properties from objects, into distinct variables.

can't find it for translation

@impodracer
Copy link
Contributor

It looks like those descriptions in 'Features' crawls the definition of MDN except Decorator. I think there's a way to crawl definition depending on current language which I do not know.

@SachaG
Copy link
Member

SachaG commented Dec 25, 2019

Oh right. Currently we get those descriptions through our own API which makes it a little harder to get the correct language. I think for now we can leave them in English, or maybe just hide them?

@seognil seognil mentioned this issue Dec 25, 2019
47 tasks
@plouc plouc added the i18n label Jan 4, 2020
@norskeld norskeld mentioned this issue Jan 15, 2020
47 tasks
@norskeld
Copy link
Contributor

norskeld commented Jan 15, 2020

Faced this issue as well. The absence of these blocks in locale file leads to displaying descriptions like on the screenshot.

image

For now, I'm adding these blocks into our locale yml for consistency of translation. @SachaG is this ok, at least as a temporary solution?

- key: block.description.proxies
  t: >
    ... [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy)

- key: block.description.async_await
  t: >
    ... [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function)

- key: block.description.promises
    ... [MDN](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants