add recording streaming to named pipe

Author: mamoreau-devolutions

dll/ApiHooks.cpp

@@ -457,6 +457,12 @@ bool WINAPI MsRdpEx_CaptureBlt(
             free(recordingPath);
         }
 
+        char* recordingPipeName = pExtendedSettings->GetRecordingPipeName();
+        if (recordingPipeName) {
+            MsRdpEx_OutputMirror_SetRecordingPipeName(outputMirror, recordingPipeName);
+            free(recordingPipeName);
+        }
+
         const char* sessionId = pExtendedSettings->GetSessionId();
         MsRdpEx_OutputMirror_SetSessionId(outputMirror, sessionId);
 

dll/CMakeLists.txt

@@ -34,6 +34,7 @@ set(MSRDPEX_HEADERS
     "${MSRDPEX_INCLUDE_DIR}/OutputMirror.h"
     "${MSRDPEX_INCLUDE_DIR}/VideoRecorder.h"
     "${MSRDPEX_INCLUDE_DIR}/RecordingManifest.h"
+    "${MSRDPEX_INCLUDE_DIR}/NamedPipe.h"
     "${MSRDPEX_INCLUDE_DIR}/MsRdpEx.h")
 
 set(MSRDPEX_SOURCES
@@ -59,6 +60,7 @@ set(MSRDPEX_SOURCES
     OutputMirror.c
     VideoRecorder.c
     RecordingManifest.c
+    NamedPipe.c
     Pcap.cpp
     Bitmap.c
     WinMsg.c

dll/NamedPipe.c

@@ -0,0 +1,89 @@
+
+#include "MsRdpEx.h"
+
+#include <MsRdpEx/NamedPipe.h>
+
+#include <fcntl.h>
+#include <errno.h>
+
+#define XMF_NAMED_PIPE_BUFFER_SIZE    8192
+
+int MsRdpEx_NamedPipe_Read(HANDLE np_handle, uint8_t* data, size_t size)
+{
+    DWORD cb_read = 0;
+    
+    if (!ReadFile(np_handle, data, size, &cb_read, NULL)) {
+        return -1;
+    }
+
+    return (int) cb_read;
+}
+
+int MsRdpEx_NamedPipe_Write(HANDLE np_handle, const uint8_t* data, size_t size)
+{
+    DWORD cb_write = 0;
+
+    if (!WriteFile(np_handle, (void*)data, (DWORD)size, &cb_write, NULL)) {
+        return -1;
+    }
+
+    return (int) cb_write;
+}
+
+HANDLE MsRdpEx_NamedPipe_Open(const char* np_name)
+{
+    HANDLE np_handle;
+    char filename[MSRDPEX_MAX_PATH];
+
+    if (!np_name)
+        return NULL;
+
+    sprintf_s(filename, sizeof(filename) - 1, "\\\\.\\pipe\\%s", np_name);
+
+    np_handle = CreateFileA(filename, GENERIC_WRITE, 0, NULL, OPEN_EXISTING, 0, NULL);
+
+    if (np_handle == INVALID_HANDLE_VALUE) {
+        return NULL;
+    }
+
+    return np_handle;
+}
+
+HANDLE MsRdpEx_NamedPipe_Create(const char* np_name, int max_clients)
+{
+    HANDLE np_handle;
+    char filename[MSRDPEX_MAX_PATH];
+
+    if (!np_name)
+        return NULL;
+
+    sprintf_s(filename, sizeof(filename) - 1, "\\\\.\\pipe\\%s", np_name);
+
+    np_handle = CreateNamedPipeA(filename,
+        PIPE_ACCESS_DUPLEX,
+        PIPE_TYPE_BYTE | PIPE_READMODE_BYTE | PIPE_WAIT,
+        max_clients,
+        XMF_NAMED_PIPE_BUFFER_SIZE,
+        XMF_NAMED_PIPE_BUFFER_SIZE,
+        0, NULL);
+
+    if (np_handle == INVALID_HANDLE_VALUE) {
+        return NULL;
+    }
+
+    return np_handle;
+}
+
+HANDLE MsRdpEx_NamedPipe_Accept(HANDLE np_handle)
+{
+    if (!ConnectNamedPipe(np_handle, NULL)) {
+        return NULL;
+    }
+    return np_handle;
+}
+
+
+void MsRdpEx_NamedPipe_Close(HANDLE np_handle)
+{
+    CloseHandle(np_handle);
+}

dll/OutputMirror.c

@@ -27,6 +27,7 @@ struct _MsRdpEx_OutputMirror
 	bool videoRecordingEnabled;
 	uint32_t videoQualityLevel;
 	char recordingPath[MSRDPEX_MAX_PATH];
+	char recordingPipeName[MSRDPEX_MAX_PATH];
 	char outputPath[MSRDPEX_MAX_PATH];
 	char sessionId[MSRDPEX_GUID_STRING_SIZE];
 	MsRdpEx_VideoRecorder* videoRecorder;
@@ -125,6 +126,11 @@ void MsRdpEx_OutputMirror_SetRecordingPath(MsRdpEx_OutputMirror* ctx, const char
 	strcpy_s(ctx->recordingPath, MSRDPEX_MAX_PATH, recordingPath);
 }
 
+void MsRdpEx_OutputMirror_SetRecordingPipeName(MsRdpEx_OutputMirror* ctx, const char* recordingPipeName)
+{
+	strcpy_s(ctx->recordingPipeName, MSRDPEX_MAX_PATH, recordingPipeName);
+}
+
 void MsRdpEx_OutputMirror_SetSessionId(MsRdpEx_OutputMirror* ctx, const char* sessionId)
 {
 	strcpy_s(ctx->sessionId, MSRDPEX_GUID_STRING_SIZE, sessionId);
@@ -207,6 +213,11 @@ bool MsRdpEx_OutputMirror_Init(MsRdpEx_OutputMirror* ctx)
 			MsRdpEx_VideoRecorder_SetFrameSize(ctx->videoRecorder, ctx->bitmapWidth, ctx->bitmapHeight);
 			MsRdpEx_VideoRecorder_SetFileName(ctx->videoRecorder, filename);
 			MsRdpEx_VideoRecorder_SetVideoQuality(ctx->videoRecorder, ctx->videoQualityLevel);
+
+			if (!MsRdpEx_StringIsNullOrEmpty(ctx->recordingPipeName)) {
+				MsRdpEx_VideoRecorder_SetPipeName(ctx->videoRecorder, ctx->recordingPipeName);
+			}
+
 			MsRdpEx_VideoRecorder_Init(ctx->videoRecorder);
 		}
 
@@ -293,7 +304,9 @@ void MsRdpEx_OutputMirror_Free(MsRdpEx_OutputMirror* ctx)
 	if (!ctx)
 		return;
 
-	MsRdpEx_OutputMirror_WriteManifestFile(ctx);
+	if (MsRdpEx_StringIsNullOrEmpty(ctx->recordingPipeName)) {
+		MsRdpEx_OutputMirror_WriteManifestFile(ctx);
+	}
 
 	MsRdpEx_OutputMirror_Uninit(ctx);
 

dll/RdpSettings.cpp

@@ -482,6 +482,7 @@ CMsRdpExtendedSettings::~CMsRdpExtendedSettings()
 {
     this->SetKdcProxyUrl(NULL);
     this->SetRecordingPath(NULL);
+    this->SetRecordingPipeName(NULL);
 
     if (m_pMsRdpExtendedSettings)
         m_pMsRdpExtendedSettings->Release();
@@ -658,6 +659,20 @@ HRESULT __stdcall CMsRdpExtendedSettings::put_Property(BSTR bstrPropertyName, VA
         free(propValue);
         hr = S_OK;
     }
+    else if (MsRdpEx_StringEquals(propName, "RecordingPipeName"))
+    {
+        if (pValue->vt != VT_BSTR)
+            goto end;
+
+        char* propValue = _com_util::ConvertBSTRToString(pValue->bstrVal);
+
+        if (propValue) {
+            hr = this->SetRecordingPipeName(propValue);
+        }
+
+        free(propValue);
+        hr = S_OK;
+        }
     else if (MsRdpEx_StringEquals(propName, "DumpBitmapUpdates"))
     {
         if (pValue->vt != VT_BOOL)
@@ -779,6 +794,12 @@ HRESULT __stdcall CMsRdpExtendedSettings::get_Property(BSTR bstrPropertyName, VA
         pValue->bstrVal = _com_util::ConvertStringToBSTR(recordingPath);
         hr = S_OK;
     }
+    else if (MsRdpEx_StringEquals(propName, "RecordingPipeName")) {
+        pValue->vt = VT_BSTR;
+        const char* recordingPipeName = m_RecordingPipeName ? m_RecordingPipeName : "";
+        pValue->bstrVal = _com_util::ConvertStringToBSTR(recordingPipeName);
+        hr = S_OK;
+    }
     else if (MsRdpEx_StringEquals(propName, "MsRdpEx_SessionId")) {
         pValue->vt = VT_BSTR;
         char sessionId[MSRDPEX_GUID_STRING_SIZE];
@@ -883,6 +904,16 @@ HRESULT __stdcall CMsRdpExtendedSettings::SetRecordingPath(const char* recording
     return S_OK;
 }
 
+HRESULT __stdcall CMsRdpExtendedSettings::SetRecordingPipeName(const char* recordingPipeName) {
+    free(m_RecordingPipeName);
+    m_RecordingPipeName = NULL;
+
+    if (recordingPipeName) {
+        m_RecordingPipeName = _strdup(recordingPipeName);
+    }
+    return S_OK;
+}
+
 HRESULT CMsRdpExtendedSettings::AttachRdpClient(IMsTscAx* pMsTscAx)
 {
     HRESULT hr;
@@ -1169,6 +1200,13 @@ HRESULT CMsRdpExtendedSettings::ApplyRdpFile(void* rdpFilePtr)
             value.vt = VT_BSTR;
             pMsRdpExtendedSettings->put_Property(propName, &value);
         }
+        else if (MsRdpEx_RdpFileEntry_IsMatch(entry, 's', "RecordingPipeName")) {
+            bstr_t propName = _com_util::ConvertStringToBSTR(entry->name);
+            bstr_t propValue = _com_util::ConvertStringToBSTR(entry->value);
+            value.bstrVal = propValue;
+            value.vt = VT_BSTR;
+            pMsRdpExtendedSettings->put_Property(propName, &value);
+        }
         else if (MsRdpEx_RdpFileEntry_IsMatch(entry, 'i', "DumpBitmapUpdates")) {
             if (MsRdpEx_RdpFileEntry_GetVBoolValue(entry, &value)) {
                 bstr_t propName = _com_util::ConvertStringToBSTR(entry->name);
@@ -1407,6 +1445,14 @@ char* CMsRdpExtendedSettings::GetRecordingPath()
     return NULL;
 }
 
+char* CMsRdpExtendedSettings::GetRecordingPipeName()
+{
+    if (m_RecordingPipeName)
+        return _strdup(m_RecordingPipeName);
+
+    return NULL;
+}
+
 bool CMsRdpExtendedSettings::GetDumpBitmapUpdates()
 {
     return m_DumpBitmapUpdates;