Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper for consistently creating PV names #42

Open
GDYendell opened this issue Jun 18, 2024 · 1 comment
Open

Add a helper for consistently creating PV names #42

GDYendell opened this issue Jun 18, 2024 · 1 comment

Comments

@GDYendell
Copy link
Contributor

Currently PV names are formatted in multiple places and risk being inconsistent. There should be a single function that creates these PV names.

This may require refactoring the Attribute / Controller / Mapping structure to allow this function to have a simple interface. Currently the places that format PV names combine the path from the controller with the name of the attribute from the mapping.

Additionally the GUI needs to manually add the prefix, whereas the IOC does builder.SetDeviceName, so the prefix should probably be an attribute of EpicsGUI and applied while making the pvi signals to make this consistent.

@GDYendell
Copy link
Contributor Author

We don't call builder.SetDeviceName as of #54, so this should be slightly simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant