Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correlation ID handling to rest endpoints. #177

Open
rosesyrett opened this issue May 11, 2023 · 4 comments
Open

Add correlation ID handling to rest endpoints. #177

rosesyrett opened this issue May 11, 2023 · 4 comments
Labels
enhancement New feature or request rest api Potential REST API changes

Comments

@rosesyrett
Copy link
Contributor

At the moment the rest api does not handle correlation ID's, but it needs to.
It seems like the client of the API should generate a correlation ID, and call the rest API endpoints with it. The rest endpoints should do things with it (e.g. submitting a task) and return it back as confirmation that stuff has been done.

@callumforrester
Copy link
Collaborator

@keithralphs does this relate to your opentelemetry work?

@keithralphs
Copy link
Contributor

Yes, this is one of my ideas for this using the baggage to pass the id , however it may be possible to accomplish automatically via context propagation if all clients are OT instrumented when the make the call as the default is for the combintaion of the current Span plus the trace id to form the correlation id. In this scheme the Trace id would identify the client and the span id , the call it made.

@callumforrester
Copy link
Collaborator

Fair enough, if that works we can close this PR I guess. Do you have that in a draft anywhere?

@keithralphs
Copy link
Contributor

Not as such. I have the server side example at #355, but it;'s not really properly addressing correlation id throughout at the moment.

@stan-dot stan-dot added the enhancement New feature or request label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request rest api Potential REST API changes
Projects
None yet
Development

No branches or pull requests

4 participants