Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Usage statistics and metrics #305

Open
DominicOram opened this issue Aug 31, 2023 · 4 comments
Open

Discussion: Usage statistics and metrics #305

DominicOram opened this issue Aug 31, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request python Pull requests that update Python code worker Relates to worker code

Comments

@DominicOram
Copy link
Contributor

As a developer I would like to be able to easily see a number of things about my plans, plan stubs and devices:

  • When was the last time this was used
  • Which beamline was it used on - maybe even who used it if we have good granularity on this
  • How long did it take

Acceptance Criteria

  • We compile a list of requirements
  • We come up with a plan of where we will implement these requirements and how
  • We write relevant issues for them

Note:

  • As discussed we may not get perfect statistics all the time e.g. my_plan on i03 may not be the same as my_plan on i04 or my_plan today may be very different from my_plan yesterday. This is fine, we shouldn't let perfect be the enemy of good
@callumforrester callumforrester self-assigned this Aug 31, 2023
@callumforrester callumforrester added the enhancement New feature or request label Aug 31, 2023
@callumforrester
Copy link
Collaborator

Additional metrics I would be interested in, some raised by in-person discussion:

  • Plan error/success rate
  • How often plan is run with the same set of parameters vs. different set
  • Unique identifier to ensure all plans tracked uniquely. Two plans can have the same name
  • Ideally also distinguish between different versions of the same plan

@Tom-Willemsen
Copy link
Contributor

  • Which device(s) were injected into the plan by blueapi (maybe just log name/class/prefix)?
    • e.g. the plan might be theoretically shared between two beamlines, but if only one beamline uses it in practice we should be able to tell from the prefixes of the injected devices.

@stan-dot stan-dot added worker Relates to worker code python Pull requests that update Python code labels Mar 8, 2024
@stan-dot
Copy link
Collaborator

stan-dot commented May 1, 2024

connected to #363 .

@stan-dot
Copy link
Collaborator

stan-dot commented May 1, 2024

suggestion - a discussion on parts that change the architecture in a major way: #133, #167, #180, #184 ,#194 #276, #258 , #257, #363, DiamondLightSource/bluesky-stomp#22, #299, #440, #380, #371

possibly most would be closed as not in scope, and if breaking changes are introduced maybe all at once would make for an easier change, leaving out only small changes and bugs, bringing us closer to 1.0

@stan-dot stan-dot added this to the Refactor of the core logic milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code worker Relates to worker code
Projects
None yet
Development

No branches or pull requests

4 participants