Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate task.dict() #435

Closed
stan-dot opened this issue Apr 25, 2024 · 3 comments
Closed

Deprecate task.dict() #435

stan-dot opened this issue Apr 25, 2024 · 3 comments
Labels
python Pull requests that update Python code

Comments

@stan-dot
Copy link
Collaborator

The method "dict" in class "BaseModel" is deprecated
The dict method is deprecated; use model_dump instead.Pylance

chante the data=task.dict() to data=task.model_dump()
@stan-dot stan-dot added the python Pull requests that update Python code label Apr 25, 2024
@callumforrester
Copy link
Collaborator

No need to deprecate use in blueapi, can just be a change as it doesn't break any APIs

@callumforrester
Copy link
Collaborator

@stan-dot can this be part of #449?

@stan-dot
Copy link
Collaborator Author

closing as part of #449

@stan-dot stan-dot closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@callumforrester @stan-dot