diff --git a/.github/workflows/_container.yml b/.github/workflows/_container.yml deleted file mode 100644 index 24a1351..0000000 --- a/.github/workflows/_container.yml +++ /dev/null @@ -1,56 +0,0 @@ -on: - workflow_call: - -jobs: - build: - runs-on: ubuntu-latest - - steps: - - name: Checkout - uses: actions/checkout@v4 - with: - # Need this to get version number from last tag - fetch-depth: 0 - - - name: Set up Docker Buildx - id: buildx - uses: docker/setup-buildx-action@v3 - - - name: Log in to GitHub Docker Registry - if: github.event_name != 'pull_request' - uses: docker/login-action@v3 - with: - registry: ghcr.io - username: ${{ github.actor }} - password: ${{ secrets.GITHUB_TOKEN }} - - - name: Build and export to Docker local cache - uses: docker/build-push-action@v5 - with: - context: . - # Need load and tags so we can test it below - load: true - tags: tag_for_testing - - - name: Test cli works in cached runtime image - run: docker run --rm tag_for_testing config-service --version - - - name: Create tags for publishing image - id: meta - uses: docker/metadata-action@v5 - with: - images: ghcr.io/${{ github.repository }} - tags: | - type=ref,event=tag - type=raw,value=latest - - - name: Push cached image to container registry - if: github.ref_type == 'tag' - uses: docker/build-push-action@v5 - # This does not build the image again, it will find the image in the - # Docker cache and publish it - with: - context: . - push: true - tags: ${{ steps.meta.outputs.tags }} - labels: ${{ steps.meta.outputs.labels }} diff --git a/.github/workflows/backend_ci.yml b/.github/workflows/backend_ci.yml index fa71f49..8645d6f 100644 --- a/.github/workflows/backend_ci.yml +++ b/.github/workflows/backend_ci.yml @@ -38,13 +38,6 @@ jobs: secrets: CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} - container: - needs: check - if: needs.check.outputs.branch-pr == '' - uses: ./.github/workflows/_container.yml - permissions: - packages: write - dist: needs: check if: needs.check.outputs.branch-pr == '' diff --git a/README.md b/README.md index 8968df5..9338ad9 100644 --- a/README.md +++ b/README.md @@ -4,10 +4,14 @@ [![PyPI](https://img.shields.io/pypi/v/daq-config-server.svg)](https://pypi.org/project/daq-config-server) [![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0) -# daq_config_server +# DAQ Config Server A service to put and get your config values from. +Comprises a FastAPI backend with a valkey database to C/R/U/D config values, and a Chakra/React frontend for easier management. + +Currently the scope is JUST storing and retrieving feature flags for Hyperion/I03 UDC but we hope to expand this to replace all DAQ config files. + | Source | | | :------: | :----------------------------------------------------------------: | | Docker | `docker run ghcr.io/DiamondLightSource/daq-config-server:latest` | diff --git a/gui/config-server-gui/src/App.tsx b/gui/config-server-gui/src/App.tsx index faa34a8..a29c16e 100644 --- a/gui/config-server-gui/src/App.tsx +++ b/gui/config-server-gui/src/App.tsx @@ -135,6 +135,7 @@ export const App = () => { placeholder="flag_name" size="md" onChange={handleChange} + onKeyDown={(event) => event.key === "Enter" && submitCreateFlag()} >