Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client failing on getting all feature flags #52

Closed
DominicOram opened this issue Jul 12, 2024 · 1 comment · Fixed by #49
Closed

Client failing on getting all feature flags #52

DominicOram opened this issue Jul 12, 2024 · 1 comment · Fixed by #49

Comments

@DominicOram
Copy link
Collaborator

When hyperion calls the config server to get all the feature flags it fails with:

[31m[E 240712 10:12:17.954 client:84] Encountered an error reading from the config service.�[0m
Traceback (most recent call last):
  File "/dls_sw/i03/software/bluesky/hyperion_v9.5.1/hyperion/.venv/lib/python3.11/site-packages/daq_config_server/client.py", line 82, in best_effort_get_all_feature_flags
    return self._get(ENDPOINTS.FEATURE, options={"get_values": "true"})
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/dls_sw/i03/software/bluesky/hyperion_v9.5.1/hyperion/.venv/lib/python3.11/site-packages/daq_config_server/client.py", line 41, in _get
    assert item in body, f"Malformed response: {body} does not contain {item}"
           ^^^^^^^^^^^^
AssertionError: Malformed response: {'set_stub_offsets': False, 'use_panda_for_gridscan': True, 'use_gpu_for_gridscan': True} does not contain None

Acceptance Criteria

  • Calling best_effort_get_all_feature_flags does not fail
  • There are tests for this
@dperl-dls
Copy link
Collaborator

This should already be fixed by #49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants