-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ophyd-async device for F-Switch #399
Comments
The f-switch is more complicated than just four motors, it has additional screens relating to filters and beamsize. It uses the "transfocator" support module. There is an implementation in dodal already: dodal/src/dodal/beamlines/i04.py Lines 141 to 153 in 18277c8
This could be converted to ophyd-async and moved to a common location as the device is currently in the i04 module. Also need to work out what functionality is needed, e.g. the current iml allows for setting the filters but for now presumably they just want to read them. The desired fields in #337 do not exist in their current GDA Nexus files. |
Also need to check the I04 transfocator PVs are the same as the I22 ones and if not get one set of PVs changed, as in #384 |
@DominicOram It turns out that the i04 f-switch contains an additional component about the beam size which is not present on i22. I'm not sure what the best approach to take is, split the current device to be composed of an optional beam size component or to make a new device? |
My first reaction would be to ask i22 if a beamsize calculator would be useful and port the logic over from i04. It looks pretty simple, take the required size, the beam energy and some other constants and put them in a quadratic equation:
@JamesOHeaDLS - how easy would it be to put this somewhere common for i22 too? |
This is an initial implementation for providing the required data for i22 Nexus files. In the future this device should be combined with the i04 version. See #399 for further details.
Required for #377
We need to implement an F-Switch device exposing the fields required for I22 nexus files (see linked issue). The F-Switch is a group of 4 motors.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: