Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beamline prefix in *_01 beamlines are wrong #570

Closed
DominicOram opened this issue May 22, 2024 · 3 comments
Closed

Beamline prefix in *_01 beamlines are wrong #570

DominicOram opened this issue May 22, 2024 · 3 comments

Comments

@DominicOram
Copy link
Contributor

For a beamlines with _1 the PV prefixes are BLXXJ rather than BLXXI e.g. i20_1 has PVs of BL20J. However, when the i20_1.py module is used it incorrectly uses BL04I. This can be seen by running dodal connect i20_1 after #519 is merged

Acceptance Criteria

  • dodal connect i20_1 correctly connects to devices
@DominicOram
Copy link
Contributor Author

FYI @stan-dot, you'll probably get round i20_1 before MX get round to any _1 beamlines so you will need to fix this first

@DominicOram DominicOram mentioned this issue May 22, 2024
Merged
3 tasks
@stan-dot
Copy link
Contributor

i20_1 beamline is on indefinite leave. The prefixes issue for it won't be a problem

@DominicOram
Copy link
Contributor Author

Duplicate of #760 but that one is better written

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DominicOram @stan-dot