Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pyright in CI for full source tree #668

Closed
rtuck99 opened this issue Jul 11, 2024 · 0 comments · Fixed by #718
Closed

Enable pyright in CI for full source tree #668

rtuck99 opened this issue Jul 11, 2024 · 0 comments · Fixed by #718

Comments

@rtuck99
Copy link
Contributor

rtuck99 commented Jul 11, 2024

Currently after migrating to python-copier-template (see #378) we had to disable the default running of pyright against the full source tree, in favour of doing diff-quality against new checkins

As of this time there are ~197 pyright failures, if we fix these we should be able to remove diff-quality and revert to the standard copier-template of doing 100% check in lint CI step

Acceptance Criteria

  • Pyright violations are fixed and lint CI runs tox -e type-checking instead of diff-quality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant