Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Rotation scans timeout at long exposures due to top up wait #1464

Closed
olliesilvester opened this issue Jun 24, 2024 · 2 comments · Fixed by DiamondLightSource/dodal#674
Closed

Rotation scans timeout at long exposures due to top up wait #1464

olliesilvester opened this issue Jun 24, 2024 · 2 comments · Fixed by DiamondLightSource/dodal#674
Assignees
@rtuck99

Comments

@olliesilvester
Copy link
Contributor

olliesilvester commented Jun 24, 2024 •
edited
Loading

With long (~0.1s) exposures, data collections can take 6 minutes or more. If Hyperion is about to start a 6 minute collection, but there is a top-up due in 5 minutes, it will wait for 5 minutes before starting. The timeout for rotations is currently 10 minutes, so this causes an error.
The simplest solution would just be to increase the time-out to ~30 mins. There are some more involved alternatives though:

  • Instead of waiting for top-up, start collection anyway and then pause during top-up.

  • While waiting for top-up, pause the rotation timeout timer
@olliesilvester
Copy link
Contributor Author

olliesilvester commented Jun 24, 2024 •
edited
Loading

After discussion with Neil, for exposure times greater than a certain value, we can just continue with collection during top-up and not worry about waiting, since the flickering beam doesn't affect things very much

@DominicOram
Copy link
Collaborator

To work out what those values are take a look at the GDA properties:

gda.mx.topup.enabled = true
gda.mx.topup.threshold_percentage = 20
gda.mx.topup.instability_time = 27

and associated code. We think it's something like "if topup instability time >20% of total exposure then wait"

@rtuck99 rtuck99 self-assigned this Jul 12, 2024
rtuck99 added a commit to DiamondLightSource/dodal that referenced this issue Jul 15, 2024
@rtuck99
(DiamondLightSource/hyperion#1464) Change topup gating to prevent gat…
50a4c60 
…ing with long exposures
@rtuck99 rtuck99 mentioned this issue Jul 16, 2024
Merged
4 tasks
rtuck99 added a commit to DiamondLightSource/dodal that referenced this issue Jul 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1464) Change topup gating to prevent gat…
15b4379 
…ing with long exposures
rtuck99 added a commit to DiamondLightSource/dodal that referenced this issue Aug 29, 2024
@rtuck99
(DiamondLightSource/hyperion#1464) Change topup gating to prevent gat…
c3ad7e4 
…ing with long exposures (#674)

* (DiamondLightSource/hyperion#1464) Change topup gating to prevent gating with long exposures

* Additional commentary as per PR review

* Fix whitespace
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rtuck99 rtuck99

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
3 participants
@rtuck99 @DominicOram @olliesilvester