Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define standard baseline list to prevent re-definition per-plan #761

Open
DiamondJoseph opened this issue May 30, 2024 · 3 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@DiamondJoseph
Copy link
Contributor

Our plans will begin to accept a list[Device] (Readable?) named baseline that are to be read at the start/end of a run in a stream named baseline.

These devices are ancillary devices that are not explicitly included in the scan logic (e.g. upstream optical components). They are likely to be consistent across multiple plans, although they may be overridden by explicitly passed arguments.

Define a list[Device|Readable] either in the dodal module or in this repository that can be re-used as the default argument for this parameter.

@stan-dot
Copy link
Contributor

for the moment I can import the baseline list or copy it into pressure_jump over from the stopflow one.
this issue sounds likely to be generic for many beamlines, what do you think about moving this issue into dodal repo today @DiamondJoseph ?

@DiamondJoseph
Copy link
Contributor Author

@stan-dot I wanted to see the conclusion of #597 because it probably changes how inject works in blueapi and may make it not required. I'm happy for this issue to move into dodal, as eventually it should be defined alongside the devices.

@DiamondJoseph DiamondJoseph transferred this issue from DiamondLightSource/i22-bluesky Aug 22, 2024
@DiamondJoseph
Copy link
Contributor Author

https://github.com/DiamondLightSource/i22-bluesky/blob/1f0a00828b006388d1a56b0f426610ab8d7bfcdf/src/i22_bluesky/plans/stopflow.py#L59

Here is an example of how this was working in the i22-bluesky plans repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants