Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify memory_gpu field in methods database entry structure #358

Open
2 tasks
yousefmoazzam opened this issue May 31, 2024 · 1 comment
Open
2 tasks
Labels
minor Nice to do but not vital

Comments

@yousefmoazzam
Copy link
Collaborator

Current structure

YAML

memory_gpu: 
   - datasets: [tomo] 
   - multipliers: [2.1] 
   - methods: [direct] 

where the value of the memory_gpu field parses into the following python:

[
  {"datasets": ["tomo"]},
  {"multipliers": [2.1]},
  {"methods": ["direct"]},
]

Goal for simplified structure

YAML

memory_gpu: 
  datasets: "tomo"
  multipliers: 2.1
  methods: "direct"

where the value of the memory_gpu field parses into the following python:

{
  "datasets": "tomo",
  "multipliers": 2.1,
  "methods": "direct",
}
@yousefmoazzam yousefmoazzam added the minor Nice to do but not vital label May 31, 2024
@team-gpu
Copy link
Contributor

Also note that this loop will have to go too. Originally there was the option to have darks and flats fields there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Nice to do but not vital
Projects
None yet
Development

No branches or pull requests

2 participants