Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrap side input from OutputRef before passing to memory estimator function #359

Open
yousefmoazzam opened this issue Jun 3, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@yousefmoazzam
Copy link
Collaborator

yousefmoazzam commented Jun 3, 2024

Suppose a side input that is passed to a method is also involved in memory estimation (such as the overlap generated by find_center_360 being passed as a side input to sino_360_to_180).

Currently, the value will be passed to the memory estimator function wrapped inside an OutputRef, rather than passing the value itself. This results in:

  • needing to unwrap the value from the OutputRef before using it in the memory estimator (not so bad)
  • in a memory estimator test that has a method using a side input, one needs to mock an OutputRef whose value property is fixed to return the value (slightly more annoying)

It feels like it may be nicer to have memory estimator function receive the wrapped value rather than an OutputRef object, so then memory estimator functions don't need to know about OutputRef and can focus solely on memory calculations.

@yousefmoazzam yousefmoazzam added the enhancement New feature or request label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant