Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary pass in elif block _build_kwargs() generic wrapper(?) #374

Open
yousefmoazzam opened this issue Jun 28, 2024 · 0 comments
Labels
minor Nice to do but not vital

Comments

@yousefmoazzam
Copy link
Collaborator

Not sure why a pass is here, given that there is some logic written for that particular elif branch:

elif p == 'axis' and p in remaining_dict_params and remaining_dict_params[p] == 'auto':
ret[p] = self.pattern.value
pass

but this feels like it's probably not doing anything and thus can be removed.

@yousefmoazzam yousefmoazzam added the minor Nice to do but not vital label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Nice to do but not vital
Projects
None yet
Development

No branches or pull requests

1 participant