Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do something with undocumented pass in GenericMethodWrapper._build_kwargs() #375

Open
yousefmoazzam opened this issue Jun 28, 2024 · 0 comments
Labels
minor Nice to do but not vital

Comments

@yousefmoazzam
Copy link
Collaborator

A bare pass with no explanation isn't great if that condition is ever hit:

elif p in self._params_with_defaults:
pass

Putting something here instead of a pass would be best, but if that can't be done, documenting why there is a pass here would be useful for developers' understanding.

@yousefmoazzam yousefmoazzam added the minor Nice to do but not vital label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Nice to do but not vital
Projects
None yet
Development

No branches or pull requests

1 participant