Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML checker fails to detect incorrect angles path in loader config #378

Open
yousefmoazzam opened this issue Jul 2, 2024 · 0 comments
Open
Labels
bug Something isn't working

Comments

@yousefmoazzam
Copy link
Collaborator

yousefmoazzam commented Jul 2, 2024

The following minimal example of a DIAD loader incorrectly configured (the path for the angles should be /entry/imaging_sum/gts_theta_value):

- method: standard_tomo
  module_path: httomo.data.hdf.loaders
  parameters:
    name: tomo
    data_path: /entry/imaging/data
    image_key_path: /entry/instrument/imaging/image_key
    rotation_angles:
        data_path: /entry/imaging_sum/gts_theta_val

reproduces the bug, where the pipeline doesn't raise any errors but it should:

(/dls/science/users/twi18192/conda-envs/httomo) [twi18192@pc0074 httomo (feature/padded-dataset-store)]$ python -m httomo check incorrect-angles-not-detected.yaml tests/test_data/k11_diad/k11-18014.nxs 
Checking that the YAML_CONFIG is properly indented and has valid mappings and tags...
Sanity check of the YAML_CONFIG was successfully done...

Checking that the first method in the pipeline is a loader...
Loader check successful!!

Checking that the paths to the data and keys in the YAML_CONFIG file match the paths and keys in the input file (IN_DATA)...
Loader paths check successful!!


Validation of pipeline YAML file is successful.
@yousefmoazzam yousefmoazzam added the bug Something isn't working label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant