You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the main branch of httomo, the 360 pipeline runs without error. However, in the gpuloop branch of httomo, it produces an error that is a result of the memory estimator not providing the output shape of the data:
The reason that this doesn't produce an error in the main branch of httomo is that in main, the _update_max_slices() function is never called, and hence, the memory estimator of the stitching function is never called.
From playing with the test 360 data, it seems that the output shape of the stitching method is able to be determined in advance by the overlap value that is outputted by the find_center_360 method and passed to the stitching method, doing something like the following:
In the
main
branch of httomo, the 360 pipeline runs without error. However, in thegpuloop
branch of httomo, it produces an error that is a result of the memory estimator not providing the output shape of the data:httomolibgpu/httomolibgpu/misc/morph.py
Line 45 in 9f0a97c
The reason that this doesn't produce an error in the
main
branch of httomo is that inmain
, the _update_max_slices()function is never called, and hence, the memory estimator of the stitching function is never called.
From playing with the test 360 data, it seems that the output shape of the stitching method is able to be determined in advance by the
overlap
value that is outputted by thefind_center_360
method and passed to the stitching method, doing something like the following:where
original_sino_width
is the width of the original 360 sinogram, andoverlap
is the overlap value produced by thefind_center_360
method.So in principle, I think the correct shape of the output of the stitching method could be returned by its memory estimator.
The text was updated successfully, but these errors were encountered: