Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#579 Use the correct dockerfile for building the release image #588

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Oct 21, 2024

Fixes #579

Now uses the main CI _container.yml workflow to publish the release image

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.28%. Comparing base (0d1f693) to head (f47f36e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #588   +/-   ##
=======================================
  Coverage   78.28%   78.28%           
=======================================
  Files          93       93           
  Lines        6801     6801           
=======================================
  Hits         5324     5324           
  Misses       1477     1477           
Components Coverage Δ
i24 SSX 57.15% <ø> (ø)
hyperion 96.47% <ø> (ø)
other 95.55% <ø> (ø)

@rtuck99 rtuck99 force-pushed the fix_github_container_workflow branch from d09efa7 to 7ac89da Compare October 21, 2024 13:41
@rtuck99 rtuck99 marked this pull request as ready for review October 21, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release workflow results in wrong docker image getting pushed to ghcr.io
1 participant