Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record readback x,y,z values of panda gridscans in nexus #597

Open
DominicOram opened this issue Oct 25, 2024 · 0 comments
Open

Record readback x,y,z values of panda gridscans in nexus #597

DominicOram opened this issue Oct 25, 2024 · 0 comments
Labels

Comments

@DominicOram
Copy link
Contributor

Following the panda gridscans we will end up with an hdf file of motor positions. We should put these into the nexus file for downstream applications to potentially use.

Following discussion on https://diamondlightsource.slack.com/archives/G017HTC55M1/p1729861842852669 the following format was decided upon:

  • The current /entry/sample/transformations/sam_{x,y,z} are changed to instead contain readback values as VDS links from the panda hdf files
  • The angle transforms are kept the same as we do not record readbacks for these
  • The depends_on chain for sam_{x,y,z} is unchanged (which means sam_z depends on omega, which is actually still setpoints but that's fine)
  • We add in a new transformation for each of sam_{x,y,z}_set next to the readbacks that holds what we were previously writing
  • The new transformations will have the same attributes except they will follow a depends_on hierarchy based on {x,y,z}_sets (except sam_z as this will still depend on omega, which will have setpoints in)
  • We add a variant (https://manual.nexusformat.org/datarules.html#variants) on sam{x,y,z} linking to @variant=sam{x,y,z}_set

Note that the data coming out of the panda may currently be in encoder counts but we want it in um. Ideally this conversion should be done in the panda when it is writing the data out

Acceptance Criteria

  • Panda readback data is put into the nexus file in the above format
  • There are tests on this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Candidates for Next Sprint
Development

No branches or pull requests

1 participant