Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I24 SSX: Issues found in v0.0.2 #75

Open
DominicOram opened this issue Dec 19, 2023 · 1 comment
Open

I24 SSX: Issues found in v0.0.2 #75

DominicOram opened this issue Dec 19, 2023 · 1 comment
Labels
I24 serial Issues relating to ssx on I24

Comments

@DominicOram
Copy link
Contributor

When testing v0.0.2 of the codebase a number of issues were found:

  • Initially no PV connections could be made, this was fixed by installing caproto. We need to look at which CA bindings we want to use in mx_bluesky and make sure we correctly have them installed
  • The beam centre in the OAV takes some time to initialise, even after the connection has been waited on. This was causing issues on startup of the move to click. To fix this on the beamline the OAV was initialised once earlier and the beam centre was only requested on click rather than all mouse events
  • There was an issue in moving to click using set and so no waiting for the pmac to finish processing the command to move x before we move y. This was fixed by using put with wait=True but it could be true in other places in the codebase
  • There are lots of instances in the log of move to click in the form of Cannot move to target thread - not fixed on beamline as it seemed to cause no issues
  • The sign of the y axis was incorrect in the EDM - not fixed on the beamline yet, we need to think about a better solution for this
  • The zoomcalibrator had to be updated to 13.5 to get the move on click to work correctly
  • Beam centre matched GDA but did not match the value on the OAV viewer
  • In general starting up the viewer and interacting with the system seemed very slow and unresponsive - this is probably due to us recreating ophyd devices every time we run anything
  • The paths to the parameter files were incorrect, rather than src/mx_bluesky/I24/serial/parameters they should be mx_bluesky/src/mx_bluesky/I24/serial/parameters - are these paths relative to where run_fixed_target was run from?
  • Nit: There were lots of points in the logs that said "Chip type is 0", it would be better to print the string of the chip type
  • Generally the behaviour of setting fiducial seems wrong, if I set the fiducial then try and return to it it does not go to the correct place.
@DominicOram DominicOram added the I24 serial Issues relating to ssx on I24 label Dec 19, 2023
@noemifrisina
Copy link
Contributor

Testing v0.0.2, part 2 - TODOs:

  • Permission issues need to be fixed, see I24: Move to click should use ophyd chip stages #54
  • For the zoomcalibrator, look at ME14E-motor.edl to figure out how to convert pixelspermicrons into motor steps, see I24 SSX: Take into account zoom in click to move #44
  • Merge changes from last testing
  • Need a better solution for paths to parameter files so that they always end up in the correct place wherever it is run from, right now they assume run_fixed_target is run from mx_bluesky
  • Workaround the value for the det_type PV which can be both a string (eiger/pilatus) or an int (0/1) depending on where it's set. Have it always as string to avoid confusion.
  • Check the whole code for places where set is used for the pmac string and replace with put
  • General tidying up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I24 serial Issues relating to ssx on I24
Projects
None yet
Development

No branches or pull requests

2 participants