Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I24 SSX: Use BlueAPI abort rather than general PV #117

Closed
DominicOram opened this issue Jun 27, 2024 · 1 comment · Fixed by #124
Closed

I24 SSX: Use BlueAPI abort rather than general PV #117

DominicOram opened this issue Jun 27, 2024 · 1 comment · Fixed by #124
Labels
I24 serial Issues relating to ssx on I24

Comments

@DominicOram
Copy link
Contributor

The SSX scripts currently use me14e_gp9 as a PV for whether we want to abort or not. The bluesky way of doing this is calling abort on the RE, this can be done through blueAPI using blueapi abort. We need to make sure that when the plan is aborted it correctly tidies up, we should do this with the contingency wrapper. We need to make sure the wrapper covers as much of the plan as possible so that if we get an abort when shutter is opening we properly close it. i.e. the chip collect will look something like:

def run_fixed_target_plan(...):
  yield from bpp.contingency_wrapper(
      _run_fixed_target_plan(...), except_plan=run_aborted_plan(...), final_plan=tidy_up_plan(...)
  )

def tidy_up_plan(..):
    # Everything after the wait for the collection to finish

def _run_fixed_target_plan(...):
    # Same as current plan up to when the collection is running then we just have the wait for it to finish
@DominicOram DominicOram added the I24 serial Issues relating to ssx on I24 label Jun 27, 2024
@DominicOram
Copy link
Contributor Author

This will be cleaner if we do DiamondLightSource/dodal#650 first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I24 serial Issues relating to ssx on I24
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant