Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimisations to TIFF image stack creation in CLEM workflow #314

Merged
merged 9 commits into from
Jul 24, 2024
Merged

Optimisations to TIFF image stack creation in CLEM workflow #314

merged 9 commits into from
Jul 24, 2024

Conversation

tieneupin
Copy link
Contributor

@tieneupin tieneupin commented Jul 3, 2024 •
edited

Partially resolves issue #313:

  • More comprehensive transfer of metadata to created image stacks
  • Improved functions used in array manipulation when creating image stacks

@tieneupin tieneupin added enhancement New feature or request server Relates to the server component cryo-clem Part of the cryo-CLEM pipeline extension labels Jul 3, 2024
@tieneupin tieneupin self-assigned this Jul 3, 2024
@tieneupin tieneupin linked an issue Jul 3, 2024 that may be closed by this pull request
TIFF image stack creation in CLEM workflow can be further optimised #313
Closed
@tieneupin tieneupin marked this pull request as ready for review July 22, 2024 17:06
@d-j-hatton
Copy link
Contributor

adjust_contrast seems to only ever be "stretch". Could it possibly take any other values?

@tieneupin
Copy link
Contributor Author

tieneupin commented Jul 23, 2024 •
edited

adjust_contrast seems to only ever be "stretch". Could it possibly take any other values?

There are different ways of adjusting contrast, so I wrote it like that in the event we decide to play around with more contrast adjustment options in the future. My bad, I should have specified in the comments directly why that was the case.

@d-j-hatton
Copy link
Contributor

Not a problem, was just wondering why the switch from bool to str

@tieneupin
Reduced needless complexity of some argument parameters, linked tuple…
2f91cc8 
…s used for validation to one another, and caught case involving incorrect validation check
@tieneupin tieneupin merged commit 42ffb99 into main Jul 24, 2024
9 checks passed
@tieneupin tieneupin deleted the tiff-upgrade branch July 24, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-j-hatton d-j-hatton d-j-hatton approved these changes

Assignees

@tieneupin tieneupin

Labels
cryo-clem Part of the cryo-CLEM pipeline extension enhancement New feature or request server Relates to the server component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TIFF image stack creation in CLEM workflow can be further optimised
2 participants
@tieneupin @d-j-hatton