Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsync flags some files as failing to transfer even though the file was successfully transferred #318

Open
tieneupin opened this issue Jul 16, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@tieneupin
Copy link
Contributor

tieneupin commented Jul 16, 2024

These appear to be false positives due to the file path changing between when the file is first detected and after it's transferred. The file is present at the destination location even though the error was triggered. Will need to figure out what changed, and how the rsync module can be optimised to prevent this from occurring further.

@tieneupin tieneupin self-assigned this Jul 16, 2024
@tieneupin tieneupin added the bug Something isn't working label Jul 16, 2024
@tieneupin tieneupin mentioned this issue Jul 16, 2024
@tieneupin
Copy link
Contributor Author

Now that Pull Request #319 has gone live, it can be seen that the successful transfer message implemented under murfey.client.tui.app (line 235) has never been triggered, even though files are successfully being transferred.

This would indicate that the error lies in the condition set(relative_filenames) - transfer_success in murfey.client.rsync (line 440), which appears to be the only occurrence in the code base of Transfer_Result being set to FAILURE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant