Skip to content

Conversation

@tieneupin
Copy link
Contributor

Live testing has shown that occasionally, there will be files with the same naming pattern as the upstream visit directories we are trying to gather and return.

This PR adds an additional if-block to verify that the search match found is a directory. The associated tests were also updated to verify that only directories are gathered and returned.

@tieneupin tieneupin self-assigned this Nov 12, 2025
@tieneupin tieneupin added bug Something isn't working server Relates to the server component labels Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.23%. Comparing base (0158ee6) to head (eb1c3d7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
- Coverage   38.24%   38.23%   -0.02%     
==========================================
  Files          97       97              
  Lines       11593    11591       -2     
  Branches     1528     1527       -1     
==========================================
- Hits         4434     4432       -2     
  Misses       6964     6964              
  Partials      195      195              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tieneupin tieneupin merged commit e292f91 into main Nov 12, 2025
31 checks passed
@tieneupin tieneupin deleted the upstream-visit-fix branch November 12, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working server Relates to the server component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants