Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EOF while buffering #6

Open
bluegaspode opened this issue Dec 19, 2010 · 1 comment
Open

EOF while buffering #6

bluegaspode opened this issue Dec 19, 2010 · 1 comment

Comments

@bluegaspode
Copy link

Hi DigitalDJ, you seem to be the most active contributor to AudioStreamer, that's why I thouht I share my findings here.

I think there is one problem, when AudioStreamer is in the AS_BUFFERING state and then an EOF from the stream turnes up.
The streamer should be put in the AS_FLUSHING_EOF state then (at the same place when an EOF happens while the state is WAITING_FOR_DATA).

Otherwise the last bits of audio will never be streamed.

Can't provide a patch, as my own code did too many changes to the original already.

@jonnyijapan
Copy link

I agree. When playing from a file, the last seconds of a file will not be played, when EOF is hit. I'll have to try to find a fix for this... in the meantime I vote this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants